Enable strict mypy checks for nethsm module #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch enables strict mypy checks for the nethsm modules that contains the code that we wrote manually as well as some refactoring that is necessary to pass these checks. Fixes: #32
robin-nitrokey
requested review from
daringer,
szszszsz,
sosthene-nitrokey and
q-nk
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 79.31% 79.44% +0.13%
==========================================
Files 782 782
Lines 13382 13389 +7
==========================================
+ Hits 10614 10637 +23
+ Misses 2768 2752 -16
☔ View full report in Codecov by Sentry. |
q-nk
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch enables strict mypy checks for the nethsm modules that contains the code that we wrote manually as well as some refactoring that is necessary to pass these checks.
Fixes: #32