Removed double Content-Type workaround #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
+ Coverage 79.89% 79.90% +0.01%
==========================================
Files 782 782
Lines 13690 13690
==========================================
+ Hits 10937 10939 +2
+ Misses 2753 2751 -2
☔ View full report in Codecov by Sentry. |
robin-nitrokey
approved these changes
Oct 12, 2023
q-nk
force-pushed
the
fix_double_content_type_workaround
branch
from
c7a169e to
d2bf9fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By fixing the bug that the HTTP header Content-Type is sent twice for the /system/update API call the corresponding workaround plus its mention in the README file, can be removed.
This closes #40