[Scrum-124] 카테고리 생성/수정 화면 구현 #180

HyomK · 2025-02-27T15:05:40Z

작업 내용

MnBottomSheet 내부 패딩 제거
MnBottomSheet headerContent 추가
카테고리 생성/추가 화면구현
카테고리 아이콘 바텀 시트 구현
pomodoroSettingBottom 라우팅 적용

체크리스트

빌드 확인
MnBottomSheet 변경내용 확인
카테고리 생성/추가 정책대로 구현되었는지 확인

동작 화면

2025-02-28.12.30.00.mov

살려주세요

...src/main/java/com/pomonyang/mohanyang/presentation/designsystem/bottomsheet/MnBottomSheet.kt

HyomK · 2025-02-27T15:16:52Z

presentation/src/main/java/com/pomonyang/mohanyang/presentation/screen/home/HomeNavigator.kt

+                    )
+                },
+                goToCategoryCreate = {
+                    navHostController.navigate(CategorySetting(categoryNo = null))


카테고리 생성의 경우 categoryNo 가 없기 때문에 해당 값으로 수정/생성 화면 분기 처리

오키 이 부분은 서버랑 협의가 나면 조금 더 수정이 될 수도 있겠다!

HyomK · 2025-02-27T15:17:22Z

...tion/src/main/java/com/pomonyang/mohanyang/presentation/screen/home/category/CategoryIcon.kt

+
+import com.mohanyang.presentation.R
+
+enum class CategoryIcon(val id: String, val resourceId: Int) {


서버와 이후 id 값 정책 통일 필요

HyomK · 2025-02-27T15:27:27Z

...in/java/com/pomonyang/mohanyang/presentation/screen/home/category/CategoryIconBottomSheet.kt

+) {
+    val borderColor = if (isSelected) MnTheme.backgroundColorScheme.accent1 else Color.Transparent
+
+    Box(


4열 정사각형을 유지하면서 56.dp 를 지키는 방법 시도하다가 결국 Box 두개를 써버렸는데 더 좋은 방법이 있을까요

이 리뷰를 놓쳤었네 지금 확인 중이야!

이것저것 도전을 해보았는데 잘 안되네 이건 Box 2개가 그냥 나을거 같아,,,

ㅋㅋㅋ 오케이..

...n/java/com/pomonyang/mohanyang/presentation/screen/home/category/CategorySettingViewModel.kt

...ava/com/pomonyang/mohanyang/presentation/screen/home/category/PomodoroCategoryBottomSheet.kt

lee-ji-hoon

아이콘 추가 노가다 고생 많았어!~~!!!

전체적인 기능에는 문제 없고 그냥 몇 개 챙겨볼만한 것들만 리뷰를 달아뒀으니 반영하고 바로 들어가도 될거 같으니 approve 하겠읍니다

lee-ji-hoon · 2025-03-01T04:25:52Z

presentation/src/main/java/com/pomonyang/mohanyang/presentation/screen/home/HomeNavigator.kt

+                    )
+                },
+                goToCategoryCreate = {
+                    navHostController.navigate(CategorySetting(categoryNo = null))


오키 이 부분은 서버랑 협의가 나면 조금 더 수정이 될 수도 있겠다!

lee-ji-hoon · 2025-03-01T04:27:24Z

presentation/src/main/java/com/pomonyang/mohanyang/presentation/screen/home/HomeNavigator.kt

+            val routeData = backStackEntry.toRoute<CategorySetting>()
+            CategorySettingRoute(categoryNo = routeData.categoryNo) {


이제 그냥 routeData를 그냥 viewModel의 savedStateHandle 에 넣는 형태로 통일을 할까 하는데 효민쓰 생각은 어때?

뭔가 categoryNo 라는 값을 viewModel에 state에 넣고서 viewModel 에서도 쓸 일이 생길 때 바로 쓸 수 있지 않을까?

음 좋아요 통일합시다 !

lee-ji-hoon · 2025-03-01T04:28:11Z

...in/java/com/pomonyang/mohanyang/presentation/screen/home/category/CategoryIconBottomSheet.kt

+@Preview
+@Composable
+private fun PreviewCategoryBottomSheet() {
+    CategoryIconBottomSheet(


여기도 MnTheme 해줘야 할거 같은데!

lee-ji-hoon · 2025-03-01T04:28:41Z

...main/java/com/pomonyang/mohanyang/presentation/screen/home/category/CategorySettingScreen.kt

+    categorySettingViewModel: CategorySettingViewModel = hiltViewModel(),
+    onBackClick: () -> Unit,
+) {
+    var showDialog by remember { mutableStateOf(false) }


rememberSaveable 이면 더 좋을거 같네!

lee-ji-hoon · 2025-03-01T04:29:15Z

...main/java/com/pomonyang/mohanyang/presentation/screen/home/category/CategorySettingScreen.kt

+}
+
+@Composable
+fun CategorySettingScreen(


이 Screen은 private이여도 될거 같으~! 외부에 노출 되는건 CategorySettingRoute 로 합시다!

lee-ji-hoon · 2025-03-01T04:29:41Z

...main/java/com/pomonyang/mohanyang/presentation/screen/home/category/CategorySettingScreen.kt

+    val focusManager = LocalFocusManager.current
+    val keyboardController = LocalSoftwareKeyboardController.current
+
+    var name by remember { mutableStateOf(categoryName) }


여기도 saveable로 갑시다~!

lee-ji-hoon · 2025-03-01T04:30:23Z

...main/java/com/pomonyang/mohanyang/presentation/screen/home/category/CategorySettingScreen.kt

+        }
+        Box(
+            modifier = Modifier
+                .absoluteOffset(x = 52.dp, y = 44.dp)


많은 사연이 있어 보이네

... 봐주십쇼..

lee-ji-hoon · 2025-03-01T05:11:51Z

...in/java/com/pomonyang/mohanyang/presentation/screen/home/category/CategoryIconBottomSheet.kt

+        contentPadding = PaddingValues(MnSpacing.xLarge),
+    ) {
+        items(icons.size) { index ->
+            val icon = icons[index]


여기 icon 말고 iconId 라고 명확하게 표기해주면 더 좋을거 겉아~!

lee-ji-hoon · 2025-03-01T05:12:31Z

...n/java/com/pomonyang/mohanyang/presentation/screen/home/category/CategorySettingViewModel.kt

+                updateState {
+                    copy(
+                        categoryNo = event.categoryNo,
+                        categoryName = event.categoryName ?: "",


categoryName 은 nullable 하지 않아서 ?: "" 빼도 될 것 같네

수정하면서 체크를 깜빡했네 감사함다

lee-ji-hoon · 2025-03-01T05:13:04Z

...n/java/com/pomonyang/mohanyang/presentation/screen/home/category/CategorySettingViewModel.kt

+        }
+    }
+
+    fun validateCategoryName(name: String): ValidationResult {


얘만 Event 안하고 ViewModel에서 그냥 public fun으로 한 이유가 있을까?

이름 변경할 때 event로 처리하면 updatestate 로 내부 ui state 를 변경해야 할 것 같은데 실제로는 validation 역할만 하고 있어서 직접 함수 호출하도록 했는데 event 가 맞을까 이부분은 나도 고민한 부분

음 아니면 validate만 하는 것이라면 그냥 object로 하나 빼서 ui에서 호출해도 괜찮을듯~!

빼서 만들까하다가 조건처리가 하나라 투머친가 하고 넣었는데 또 정책이 생길 수도 있으니까 빼는걸로 합시다 ㄱㄱ

lee-ji-hoon · 2025-03-01T05:13:42Z

...in/java/com/pomonyang/mohanyang/presentation/screen/home/category/CategorySettingElements.kt

+    val categoryNo: Int? = null,
+    val categoryName: String = "",
+    val selectedCategoryIcon: Int = CategoryIcon.DEFAULT.resourceId,
+    val categoryIcons: List<Int> = CategoryIcon.entries.map { it.resourceId }.toImmutableList(),


toImmutableList 로 했지만 일반 List로 타입을 지정해둬서 ImmutableList가 안 되어어서 수정 필요해보여!

HyomK added 10 commits February 23, 2025 22:03

feat: 카테고리 수정/삭제 Screen UI 구현

09016c4

feat: CategoryIcon 클래스 및 리소스 추가

24e96bf

feat: MnBottomSheet headerContents 추가 + 기본 패딩제거

7528b48

feat: MnBottomSheet 변경 내용 적용

09314ef

feat: CategoryBottomSheet 구현

64455de

feat: CategorySettingViewModel 구현

299e473

feat: CategorySetting 라우터 추가

06183c2

feat: PomodoroSetting 에 카테고리 변경 이벤트 추가

b5e4de1

feat: 임시 카테고리 수정 라우팅 적용

10163ad

feat: 카테고리 이름 정책 validation 추가

2d0a017

HyomK added the feature 기능 개발 label Feb 27, 2025

HyomK temporarily deployed to Debug February 27, 2025 15:05 — with GitHub Actions Inactive

github-actions bot requested a review from lee-ji-hoon February 27, 2025 15:05

github-actions bot assigned HyomK Feb 27, 2025

HyomK commented Feb 27, 2025

View reviewed changes

...src/main/java/com/pomonyang/mohanyang/presentation/designsystem/bottomsheet/MnBottomSheet.kt Show resolved Hide resolved

refactor: grid cell 방식 수정

59299b8

HyomK temporarily deployed to Debug February 27, 2025 15:27 — with GitHub Actions Inactive

HyomK commented Feb 27, 2025

View reviewed changes

lee-ji-hoon approved these changes Mar 1, 2025

View reviewed changes

HyomK added 2 commits March 1, 2025 23:05

refactor: naming 변경 및 savable 적용

39e35b3

refactor: CategoryNameVerifier 분리

ecb73ac

HyomK temporarily deployed to Debug March 1, 2025 14:19 — with GitHub Actions Inactive

HyomK temporarily deployed to Debug March 1, 2025 14:23 — with GitHub Actions Inactive

refactor: 불필요함수제거

4da202a

HyomK force-pushed the SCRUM-124 branch from afda37f to 4da202a Compare March 1, 2025 14:24

HyomK temporarily deployed to Debug March 1, 2025 14:24 — with GitHub Actions Inactive

HyomK merged commit 90e2669 into develop Mar 1, 2025
1 check passed

HyomK deleted the SCRUM-124 branch March 1, 2025 14:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Scrum-124] 카테고리 생성/수정 화면 구현 #180

[Scrum-124] 카테고리 생성/수정 화면 구현 #180

HyomK commented Feb 27, 2025 •

edited by lee-ji-hoon

Loading

HyomK Feb 27, 2025

lee-ji-hoon Mar 1, 2025

HyomK Feb 27, 2025

HyomK Feb 27, 2025

lee-ji-hoon Mar 1, 2025

lee-ji-hoon Mar 1, 2025

HyomK Mar 1, 2025

lee-ji-hoon left a comment

lee-ji-hoon Mar 1, 2025

lee-ji-hoon Mar 1, 2025

HyomK Mar 1, 2025

lee-ji-hoon Mar 1, 2025

lee-ji-hoon Mar 1, 2025

lee-ji-hoon Mar 1, 2025

lee-ji-hoon Mar 1, 2025

lee-ji-hoon Mar 1, 2025

HyomK Mar 1, 2025

lee-ji-hoon Mar 1, 2025

lee-ji-hoon Mar 1, 2025

HyomK Mar 1, 2025

lee-ji-hoon Mar 1, 2025

HyomK Mar 1, 2025

lee-ji-hoon Mar 1, 2025

HyomK Mar 1, 2025

lee-ji-hoon Mar 1, 2025


		import com.mohanyang.presentation.R

		enum class CategoryIcon(val id: String, val resourceId: Int) {

		val routeData = backStackEntry.toRoute<CategorySetting>()
		CategorySettingRoute(categoryNo = routeData.categoryNo) {

[Scrum-124] 카테고리 생성/수정 화면 구현 #180

[Scrum-124] 카테고리 생성/수정 화면 구현 #180

Conversation

HyomK commented Feb 27, 2025 • edited by lee-ji-hoon Loading

작업 내용

체크리스트

동작 화면

살려주세요

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lee-ji-hoon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HyomK commented Feb 27, 2025 •

edited by lee-ji-hoon

Loading