-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BrainDecode Plot #340
BrainDecode Plot #340
Conversation
Change default value n_classes=None
# Conflicts: # examples/plot_BrainDecode.py
Co-authored-by: Sylvain Chevallier <sylvain.chevallier@universite-paris-saclay.fr>
Co-authored-by: Sylvain Chevallier <sylvain.chevallier@universite-paris-saclay.fr>
# Conflicts: # examples/plot_BrainDecode2.py # moabb/pipelines/deep_learning_BrainDecode.py
Hi @carraraig, After carefully considering our problem, I have concluded that the best approach is to avoid modifying the braindecode side. Upon studying the InputerSetter callback, I have discerned that it presents the most viable alternative. Accordingly, I have devised a new callback that allows us to access the relevant shape information. We may also develop a series of model-specific functions to streamline the process further. While I acknowledge that there may be room for improvement, I think that we can optimise the parser and setter functions. |
Very nice idea for that! I've only see that if I create the EEGNetV4 as model = EEGNetv4( and as model = EEGNetv4( we get slightly different result, you know why? |
Hi @carraraig, It is a good idea set the EEGNetV4 with these dummy values, and it makes sense. I am still thinking about the second problem of defining the pytorch model with a "lazy" approach. I don't know why )= maybe some deterministic flag? |
…he reinitialize model if the shape change.
Hi @carraraig and @sylvchev, Now with InputSetterEEG, we are able to run the ShallowNet. I don't know if this is a good solution, but it is working. |
Ok nice, I'll check this |
@carraraig, I change the inputSetterEEG to reinitialise the model instead of changing the input layers. Can you test if the behaviour you reported is gone? |
I've tryed and with the first option the code is not running. Is the same for you? |
Add an example of usage of BrainDecode