-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make queue size of MetricJsonListener configurable #1109
Comments
Yeah, this sounds like an OK thing to do. I'm happy to review a PR for this. |
My upstream git config got messed up, I'll probably have to rewrite the history and force-push. I'll let you know once its done, there should only be the original two commits I had. |
#1109 Make queue size of MetricJsonListener configurable
Closed via #1114 |
Thanks, @mattrjacobs! |
@mattrjacobs Any updates on when 1.4.25 might be released? I'm assuming this change goes in the 1.4.25 release. |
…ng additional queueSize=<int> parameter in stream query
…property hystrix.stream.defaultMetricListenerQueueSize (still defaults to 1000 if unspecified)
Just released in 1.4.25: https://github.com/Netflix/Hystrix/releases/tag/v1.4.25 Haven't done a release out of master yet - I need to evaluate a couple other changes/proposals before I cut that. |
Currently, the MetricJsonListener in the hystrix-metrics-event-stream collects metrics into a queue which is hard-coded to a size of 1000. Our system has a very high request rate, hence this queue gets populated quite soon when pulling the metrics stream. While we're using version 1.4.23 right now, the latest RC also has the same issue.
Could this queue size be made configurable, perhaps with a default set to the current value of 1000, in order to allow more flexibility for larger systems? Also, if this is agreeable, and the change is included in the current/next release candidate, what would be an approximate ETA on the next release?
The text was updated successfully, but these errors were encountered: