Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make queue size of MetricJsonListener configurable #1109

Closed
anuragw opened this issue Feb 29, 2016 · 6 comments
Closed

Make queue size of MetricJsonListener configurable #1109

anuragw opened this issue Feb 29, 2016 · 6 comments

Comments

@anuragw
Copy link
Contributor

anuragw commented Feb 29, 2016

Currently, the MetricJsonListener in the hystrix-metrics-event-stream collects metrics into a queue which is hard-coded to a size of 1000. Our system has a very high request rate, hence this queue gets populated quite soon when pulling the metrics stream. While we're using version 1.4.23 right now, the latest RC also has the same issue.

Could this queue size be made configurable, perhaps with a default set to the current value of 1000, in order to allow more flexibility for larger systems? Also, if this is agreeable, and the change is included in the current/next release candidate, what would be an approximate ETA on the next release?

@mattrjacobs
Copy link
Contributor

Yeah, this sounds like an OK thing to do. I'm happy to review a PR for this.

@anuragw
Copy link
Contributor Author

anuragw commented Mar 10, 2016

My upstream git config got messed up, I'll probably have to rewrite the history and force-push. I'll let you know once its done, there should only be the original two commits I had.

mattrjacobs added a commit that referenced this issue Mar 11, 2016
#1109 Make queue size of MetricJsonListener configurable
@mattrjacobs
Copy link
Contributor

Closed via #1114

@anuragw
Copy link
Contributor Author

anuragw commented Mar 14, 2016

Thanks, @mattrjacobs!

@anuragw
Copy link
Contributor Author

anuragw commented Mar 15, 2016

@mattrjacobs Any updates on when 1.4.25 might be released? I'm assuming this change goes in the 1.4.25 release.

mattrjacobs pushed a commit to mattrjacobs/Hystrix that referenced this issue Mar 16, 2016
…ng additional queueSize=<int> parameter in stream query
mattrjacobs pushed a commit to mattrjacobs/Hystrix that referenced this issue Mar 16, 2016
…property hystrix.stream.defaultMetricListenerQueueSize (still defaults to 1000 if unspecified)
mattrjacobs pushed a commit to mattrjacobs/Hystrix that referenced this issue Mar 16, 2016
@mattrjacobs
Copy link
Contributor

Just released in 1.4.25: https://github.com/Netflix/Hystrix/releases/tag/v1.4.25

Haven't done a release out of master yet - I need to evaluate a couple other changes/proposals before I cut that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants