Cleanups and Code Structure Improvements #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You may be able to create many curve shapes, depending on the classes you use. Yet, we only provide convenient factory methods for affine curves. See also question NetCal/DNC#86
matyesz
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PR NetCal/DNC#93
The additions make changes needed to break the assumption that all curve backends will work with the same static util methods -- or, put differently, that all curve backends will implement the DNC interface. Ultimately, this is a step towards wrapping the RTC MPA toolbox and using it as a backend for our analyses without duplicating curve util code (see NetCal/DNCext_MPARTC#14 and NetCal/DNC#86).