Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

background maps and menu tweaks #888

Merged
merged 10 commits into from
Feb 14, 2025

Conversation

AdamTadeusz
Copy link
Contributor

@AdamTadeusz AdamTadeusz commented Feb 14, 2025

Description

Relies on neoAssets PR ---->NeotokyoRebuild/neoAssets#23 <-----

By no means a finished menu look, but something I hope will give people a bit more faith in the project. I have hidden the profile and news section from the main menu for now, I plan to re-introduce these later or after the neoui refactor is complete. Also want to add a music player to the main menu (main menu music currently stops playing when loading into any map, including background maps) and buttons for the tutorial and firing range, once those are complete.

I know there were some problems with the title font on linux, this PR removes the linux specific font sizings but introduces y-res values for all the font sizes, which at least on Windows will force the font to the correct size instead of letting the system pick the right font size. If someone on Linux could verify that the main menu looks good on different screen resolutions I would be thankful.

The title font is also of course not final.

@AdamTadeusz AdamTadeusz marked this pull request as draft February 14, 2025 09:04
@AdamTadeusz AdamTadeusz added the Changes in neoAssets This PR depends on changes in the neoAssets repository. The relevant PR should be in the description label Feb 14, 2025
@AdamTadeusz AdamTadeusz marked this pull request as ready for review February 14, 2025 09:08
@AdamTadeusz AdamTadeusz requested a review from a team February 14, 2025 13:17
@AdamTadeusz AdamTadeusz requested a review from a team February 14, 2025 19:36
Copy link
Contributor

@brysondev brysondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AdamTadeusz AdamTadeusz merged commit f18c689 into NeotokyoRebuild:master Feb 14, 2025
7 checks passed
@AdamTadeusz AdamTadeusz deleted the 142_hotMenus branch February 14, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes in neoAssets This PR depends on changes in the neoAssets repository. The relevant PR should be in the description
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants