-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
background maps and menu tweaks #888
Merged
AdamTadeusz
merged 10 commits into
NeotokyoRebuild:master
from
AdamTadeusz:142_hotMenus
Feb 14, 2025
Merged
background maps and menu tweaks #888
AdamTadeusz
merged 10 commits into
NeotokyoRebuild:master
from
AdamTadeusz:142_hotMenus
Feb 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agiel
approved these changes
Feb 14, 2025
brysondev
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes in neoAssets
This PR depends on changes in the neoAssets repository. The relevant PR should be in the description
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relies on neoAssets PR ---->NeotokyoRebuild/neoAssets#23 <-----
By no means a finished menu look, but something I hope will give people a bit more faith in the project. I have hidden the profile and news section from the main menu for now, I plan to re-introduce these later or after the neoui refactor is complete. Also want to add a music player to the main menu (main menu music currently stops playing when loading into any map, including background maps) and buttons for the tutorial and firing range, once those are complete.
I know there were some problems with the title font on linux, this PR removes the linux specific font sizings but introduces y-res values for all the font sizes, which at least on Windows will force the font to the correct size instead of letting the system pick the right font size. If someone on Linux could verify that the main menu looks good on different screen resolutions I would be thankful.
The title font is also of course not final.