-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input for setting custom player model #834
Input for setting custom player model #834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor things. Also feel free to just move the bool down a few lines instead of adding "private:".
Oh also, if you could update the description to include the referenced NeoAssets PR as well that would be appreciated. Example: #736 |
Co-authored-by: brysondev <bryson@brysondev.ca>
Would it be worth adding a check whether the model the player is set to is one of the models for which we do have gibs, so that we can re-enable gibs for a player without having to respawn them? |
Potentially, but I don't really think it's worth it since players can choose their own skin before spawning so there's not much reason to use this input to pick another one. Unless it's switching back from a custom model to a regular one, there's no way of getting the player's skin from map logic so it wouldn't be consistent with what they chose anyway. |
Description
Input for the player entity that sets the player model as determined by the path included in the input parameters
It will also disable gibbing on that player until they respawn so their corpse is consistent with the model change
Assets PR: NeotokyoRebuild/neoAssets#17
Toolchain
Linked Issues