Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input for setting custom player model #834

Merged
merged 4 commits into from
Jan 11, 2025

Conversation

DESTROYGIRL
Copy link
Contributor

@DESTROYGIRL DESTROYGIRL commented Dec 18, 2024

Description

Input for the player entity that sets the player model as determined by the path included in the input parameters
It will also disable gibbing on that player until they respawn so their corpse is consistent with the model change
Assets PR: NeotokyoRebuild/neoAssets#17

Toolchain

  • Windows MSVC VS2022

Linked Issues

@DESTROYGIRL DESTROYGIRL requested a review from a team December 18, 2024 23:33
@DESTROYGIRL DESTROYGIRL linked an issue Dec 20, 2024 that may be closed by this pull request
@DESTROYGIRL DESTROYGIRL added the feature New features for NT;RE label Dec 30, 2024
Copy link
Contributor

@brysondev brysondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor things. Also feel free to just move the bool down a few lines instead of adding "private:".

@brysondev
Copy link
Contributor

Oh also, if you could update the description to include the referenced NeoAssets PR as well that would be appreciated.

Example: #736

Co-authored-by: brysondev <bryson@brysondev.ca>
@AdamTadeusz
Copy link
Contributor

Would it be worth adding a check whether the model the player is set to is one of the models for which we do have gibs, so that we can re-enable gibs for a player without having to respawn them?

@DESTROYGIRL
Copy link
Contributor Author

Would it be worth adding a check whether the model the player is set to is one of the models for which we do have gibs, so that we can re-enable gibs for a player without having to respawn them?

Potentially, but I don't really think it's worth it since players can choose their own skin before spawning so there's not much reason to use this input to pick another one. Unless it's switching back from a custom model to a regular one, there's no way of getting the player's skin from map logic so it wouldn't be consistent with what they chose anyway.

@brysondev brysondev requested a review from a team January 10, 2025 11:07
@brysondev brysondev merged commit fb47c55 into NeotokyoRebuild:master Jan 11, 2025
7 checks passed
@DESTROYGIRL DESTROYGIRL deleted the inputsetplayermodel branch January 12, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features for NT;RE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Input to set player model
5 participants