Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neo_bloom_controller #827

Merged

Conversation

AdamTadeusz
Copy link
Contributor

Description

Adds neo_bloom_controller for backwards compatibility with older maps. Values controlled by this entity can be controlled with env_tonemap_controller already, unless the original purpose of this was to control the custom bloom that grey supposedly implemented, in which case this is a bandaid fix untill we can implement the custom bloom (not a clue in the world how we would go about doing that).

Toolchain

  • Windows MSVC VS2022
  • Linux GCC Distro Native [Specify distro + GCC version]
  • Linux GCC 10 Sniper 3.0

Linked Issues

@AdamTadeusz AdamTadeusz requested a review from a team December 11, 2024 16:12
Copy link
Contributor

@brysondev brysondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but as per the comment I made we really should decide on an "update" control value and not base it off "old maps". All of them should be recompiled for the engine update, and therefore should reflect it.

brysondev
brysondev previously approved these changes Jan 3, 2025
@brysondev brysondev requested a review from a team January 3, 2025 14:51
@AdamTadeusz AdamTadeusz requested a review from brysondev February 6, 2025 15:44
@DESTROYGIRL DESTROYGIRL merged commit f67dac7 into NeotokyoRebuild:master Feb 6, 2025
7 checks passed
@AdamTadeusz AdamTadeusz deleted the 113_neoBloomController branch February 6, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

neo_bloom_controller is not implemented
3 participants