Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIP and TDM Game modes #588

Merged
merged 26 commits into from
Oct 8, 2024
Merged

Conversation

AdamTadeusz
Copy link
Contributor

@AdamTadeusz AdamTadeusz commented Sep 15, 2024

Description

Materials in NeotokyoRebuild/neoAssets#5

Adds support for VIP and TDM gamemodes

Toolchain

  • Windows MSVC VS2022
  • Linux GCC Distro Native [Specify distro + GCC version]
  • Linux GCC 10 Sniper 3.0

Linked Issues

@AdamTadeusz AdamTadeusz marked this pull request as draft September 15, 2024 10:54
@AdamTadeusz AdamTadeusz marked this pull request as ready for review September 16, 2024 10:12
@blaberry blaberry modified the milestones: QoL, Plugin Parity Sep 16, 2024
@AdamTadeusz AdamTadeusz requested a review from a team September 16, 2024 12:15
@AdamTadeusz AdamTadeusz marked this pull request as draft September 17, 2024 15:05
@AdamTadeusz AdamTadeusz marked this pull request as ready for review September 17, 2024 16:35
@AdamTadeusz AdamTadeusz marked this pull request as draft September 20, 2024 15:09
@AdamTadeusz AdamTadeusz added the Changes in neoAssets This PR depends on changes in the neoAssets repository. The relevant PR should be in the description label Sep 21, 2024
@AdamTadeusz AdamTadeusz marked this pull request as ready for review September 21, 2024 08:36
@nullsystem nullsystem requested a review from a team September 22, 2024 18:12
Copy link
Collaborator

@nullsystem nullsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When disconnecting then reconnecting (both local server) while the message comes along, I was able to get the text to this overlapping state:
overlayntocleared

Also regarding cap zones, the HUD for those I think could be disabled for TDM as there's no ghost play anyway, and for VIP, only disabled for the cap that the VIP won't be going to and HUD indicator text named different like "VIP Escape Zone" or something like that.

@kassibuss
Copy link
Contributor

for VIP, only disabled for the cap that the VIP won't be going to and HUD indicator text named different like "VIP Escape Zone" or something like that.

Since there is a cvar for dropping the ghost after VIP dies, you could probably make the indicator contextual or something along those lines, so when the VIP dies it changes back to the ctg text

@AdamTadeusz
Copy link
Contributor Author

When disconnecting then reconnecting (both local server) while the message comes along, I was able to get the text to this overlapping state: overlayntocleared

Also regarding cap zones, the HUD for those I think could be disabled for TDM as there's no ghost play anyway, and for VIP, only disabled for the cap that the VIP won't be going to and HUD indicator text named different like "VIP Escape Zone" or something like that.

Although not ideal, the ghost cap indicators are a good indicator also of where the enemy team spawns, so I didn't touch them for that reason. As for the text I think it fits both game modes. Maybe we can change these in the future if people don't like them? I have code for the ATK game mode that I could then reuse to toggle capzone visibility

@nullsystem
Copy link
Collaborator

nullsystem commented Sep 22, 2024

@AdamTadeusz It's not something I'll block the PR over anyway as it's just HUD, but it's just like it has no functionality for TDM or different/partial for VIP verses CTG. As for the enemy spawn point, it'll be better to have like a rough-middle guide of all enemy's spawn as opposite to relying on caps, especially since some caps can be fairly wide away from the spawn. Or as an entity or simply a XYZ coord as a point to mark on map for such spawn-guide TDM HUD.

@nullsystem
Copy link
Collaborator

Nevertheless, you can just split it out as a separate thing to look at later.

nullsystem
nullsystem previously approved these changes Sep 24, 2024
@nullsystem nullsystem requested a review from a team September 24, 2024 19:41
@AdamTadeusz AdamTadeusz requested a review from nullsystem October 3, 2024 13:55
@nullsystem nullsystem requested a review from a team October 6, 2024 22:54
@AdamTadeusz AdamTadeusz merged commit 8557be8 into NeotokyoRebuild:master Oct 8, 2024
6 checks passed
@AdamTadeusz AdamTadeusz deleted the 038_VIPFixes branch October 8, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes in neoAssets This PR depends on changes in the neoAssets repository. The relevant PR should be in the description
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants