Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Int+acc attacker dmg tracking, spawn reset accumlator, fix menu timeout #497

Merged

Conversation

nullsystem
Copy link
Collaborator

Description

  • Instead of single float health variable, it's now accumlated quite like how CBaseCombatCharacter::OnTakeDamage_Alive does it
  • Minor refactor to utilize the AttackersTotals struct more
  • Fix accumlator not being reset in spawn
  • Fix menu timeout being restricted to 5s max, just removed the usage of the global timeout
  • Attacker info menu timeout increased to 60s

Toolchain

  • Linux GCC Distro Native Arch/GCC 14

Linked Issues

…menu timeout

* Instead of single float health variable, it's now accumlated quite
  like how `CBaseCombatCharacter::OnTakeDamage_Alive` does it
* Minor refactor to utilize the AttackersTotals struct more
* Fix accumlator not being reset in spawn
* Fix menu timeout being restricted to 5s max, just removed the usage of
  the global timeout
* Attacker info menu timeout increased to 60s
* fixes NeotokyoRebuild#309
@nullsystem nullsystem requested a review from a team July 9, 2024 22:31
@AdamTadeusz AdamTadeusz requested a review from a team July 12, 2024 11:03
@nullsystem nullsystem merged commit 1a91e2a into NeotokyoRebuild:master Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Less lazy way on tracking attackers HP damages
3 participants