Bullet penetration #473
Merged
Bullet penetration #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… decals from penetrating bullets yet.
AdamTadeusz
force-pushed
the
003_bulletPenetration
branch
from
69782dc to
3de5b93
Compare
|
See attached for help when reviewing https://discord.com/channels/1235346473827434517/1235355938458701874/1258449260513591368 |
|
I haven't really tested materials that have a "gamematerial" value defined in surfaceproperties.txt but are not on bonahnsa's website, so some values will definitely require more tweaking but I will have to remake the penetration test map to accommodate those |
Rainyan
reviewed
Jul 4, 2024
…tration_depth to allow penetration up to 11.999 (hoping 12hu will still be unpenetrable because of some rounding or shit like that)
…Weapon PrimaryAttack to support this change
Rainyan
requested changes
Jul 5, 2024
Rainyan
requested changes
Jul 6, 2024
Rainyan
previously approved these changes
Jul 6, 2024
nullsystem
reviewed
Jul 8, 2024
nullsystem
previously approved these changes
Jul 8, 2024
|
What I think I'm gonna do next time is include helpful readouts and then have a commit where they are removed clearly marked before I request a review so reviewers can insert the readouts themselves by inspecting that particular commit. |
nullsystem
approved these changes
Jul 13, 2024
Rainyan
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Toolchain
Linked Issues