Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A binding does not work properly #799

Closed
vchimev opened this issue May 15, 2017 · 2 comments · Fixed by #806
Closed

A binding does not work properly #799

vchimev opened this issue May 15, 2017 · 2 comments · Fixed by #806
Assignees
@sis0k0
Labels
bug
Milestone
3.1

Comments

@vchimev
Copy link
Contributor

vchimev commented May 15, 2017 •
edited
Loading

The item-detail component of the default hello world template does not render properly. In particular:

<Label class="h2" [text]="item.id + '. '"></Label>

Expected:
10. Messi
screen shot 2017-05-15 at 9 16 29 am

Actual:
10Messi
screen shot 2017-05-15 at 9 04 11 am
@NickIliev
Copy link

This is happening only when using FULL STOP (\u002E) but works with other symbols like COMMA(\u002C)

@sis0k0 sis0k0 removed the backlog label May 16, 2017
@sis0k0 sis0k0 added this to the 3.1 TBD milestone May 16, 2017
@sis0k0
Copy link
Contributor

sis0k0 commented May 16, 2017

If you try to add text: "4.", the ns renderer will try to convert the string to number. Result: 4 (without decimal point). With NS 3.0 such conversions are no longer needed. I'll make a PR that removes the convert function from the renderer.

@sis0k0 sis0k0 self-assigned this May 16, 2017
sis0k0 added a commit that referenced this issue May 16, 2017
@sis0k0
fix(renderer): stop performing value conversions
0e2a1a4 
These conversions are now handled by core modules. The conversions
performed in the renderer and value accessors are no longer needed.

fixes #799
@sis0k0 sis0k0 mentioned this issue May 16, 2017
Merged
sis0k0 added a commit that referenced this issue May 19, 2017
@sis0k0
fix(renderer): stop performing value conversions
ec14c88 
These conversions are now handled by core modules. The conversions
performed in the renderer and value accessors are no longer needed.

fixes #799
sis0k0 added a commit that referenced this issue May 19, 2017
@sis0k0
fix(renderer): stop performing value conversions (#806)
354074d 
These conversions are now handled by core modules. The conversions
performed in the renderer and value accessors are no longer needed.

fixes #799
vchimev pushed a commit to NativeScript/functional-tests that referenced this issue May 29, 2017
Update TemplateHelloWorldNg Tests
3d69921 
NativeScript/nativescript-angular#799
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sis0k0 sis0k0

Labels
bug
Projects
None yet
Milestone
3.1
Development

Successfully merging a pull request may close this issue.

fix(renderer): stop performing value conversions NativeScript/nativescript-angular
4 participants
@vakrilov @sis0k0 @vchimev @NickIliev