Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the ability to set a maximum height of the legend #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nathan219
Copy link
Owner

This PR adds the ability to set a maximum height for the legend. As far as I know, there is no way to currently do this, so (in combination with the negative anchor bug), causes large legends to completely block the graph. Without this, it's almost impossible to make sure the legend has enough extra room to fit.

Please help me add this functionality

Before opening a pull request, developer should:

  • git rebase their local branch off the latest master,
  • make sure to not git add the dist/ folder (the dist/ is updated only on version bumps),
  • make sure to commit changes to the package-lock.json file (if any),
  • write an overview of what the PR attempts to do,
  • select the Allow edits from maintainers option (see this article for more details).

Note that it is forbidden to force push (i.e. git push -f) to remote branches associated with opened pull requests. Force pushes make it hard for maintainers to keep track of updates. Therefore, if required, please git merge master into your PR branch instead of git rebase master.

@Nathan219
Copy link
Owner Author

@Nathan219 Nathan219 self-assigned this Oct 25, 2018
@etpinard
Copy link

etpinard commented Oct 26, 2018

@Nathan219 Thanks for the PR!

Could you point us to which issue you're trying to solve?

@etpinard
Copy link

etpinard commented Oct 26, 2018

This might conflict with the upgoing plotly#3024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants