perf: use last_scheduled_task_id for dueSchedules query #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaliqgant
reviewed
Jun 20, 2024
| ); | ||
| }); | ||
| }) | ||
| .debug(true) |
There was a problem hiding this comment.
guessing this debug is temporary?
There was a problem hiding this comment.
no i forgot to remove it
TBonnin
force-pushed
the
tbonnin/due-schedule-query-v2
branch
from
17faf40 to
d87d5f7
Compare
scanning tasks table to determine if a schedule has a running task or had a recently run task doesn't scale we are now using the last_scheduled_task_id column in schedules to avoid heavy subqueries
TBonnin
force-pushed
the
tbonnin/due-schedule-query-v2
branch
from
d87d5f7 to
9c2d89c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scanning tasks table to determine if a schedule has a running task or had a recently run task doesn't scale
we are now using the last_scheduled_task_id column in schedules to avoid heavy subqueries
Checklist before requesting a review (skip if just adding/editing APIs & templates)