fix(logs.v1): remove auth, action, hooks #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodinsamuel
commented
Jun 19, 2024
| logCtx: LogContext; | ||
| }): Promise<void> => { | ||
| await errorNotificationService.auth.create({ | ||
| type: 'auth', | ||
| action: 'token_refresh', | ||
| connection_id: connection.id!, | ||
| activity_log_id: activityLogId, | ||
| activity_log_id: -1, |
There was a problem hiding this comment.
This will be removed soon, just want to avoid a db migration along with code change
khaliqgant
reviewed
Jun 19, 2024
| @@ -169,7 +175,7 @@ export default class SyncRun { | |||
| this.writeToDb = config.writeToDb; | |||
| if (config.writeToDb) { | |||
| this.slackNotificationService = config.slackService; | |||
| this.activityLogId = config.activityLogId; | |||
| this.activityLogId = config.activityLogId as unknown as number; | |||
There was a problem hiding this comment.
This cast mixed with the one below that casts it to a string is confusing
There was a problem hiding this comment.
true, it's only temporary during the transition but let me change that
khaliqgant
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Contributes to https://linear.app/nango/issue/NAN-585/stop-writing-from-v1
Remove activities from Account, Auth, Action and Hooks
Initially wanted less but turns out everything is super tied (surprising).
Temporarily allowed activityLogId to be string in the relevant places