Adding changes due to https://github.com/pytorch/pytorch/pull/8660 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But this will break builds with earlier pytorch versions? |
|
In some cases, I locked in local copies of upstream code to make us less vulnerable to upstream changes. The type conversion templates are one of those cases. I will make the sure build works tomorrow in a backward-and-current compatible way. |
|
Gotcha. Sounds good :) |
Co-authored-by: Michael Carilli <mcarilli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build was breaking against upstream PyTorch. Could have just changed the header to the local
CUDATypeConversion.cuhbut decided to keep things consistent with the ustream PR.