-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Temperature Capacitance Multiplier to 7.0 #1223
Conversation
# Different than HPXML defaults, based on work from Jeff Maguire and Yueyue | ||
# Discussion located in issue 1161 and will likely need to get updated later. | ||
hpxml_header.temperature_capacitance_multiplier = 7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI there is a BuildResHPXML measure argument for this: https://github.com/NREL/OpenStudio-HPXML/blob/master/BuildResidentialHPXML/measure.rb#L114-L117.
We could either control it using the yml file (requires bsb updates) or using the options lookup (like simulation_control_daylight_saving_enabled
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joseph-robertson : Thanks, I like the options_lookup suggestion. Are you able to revert this and then stub it out in options_lookup. This way it will be easy to change the value and when we all decide as a group what value to use, then we can switch it back to auto.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted the change to hpxml-measures. Instead, I'm just setting capacitance=7.0 in ResStockArguments (assuming 7.0 for all datapoints).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's pretty much how I would have done it, looks good! Still investigating the exact number we should use but 7 is better than 1 for sure.
…an regenerate the artifact plots and look at the new unmet hours. Hopefully this leads to a lot less discrepancy in unmet hours?
…cap_mult_update
…pushed resetting this to 1.0. Back to 7.0.
… into temp_cap_mult_update
@@ -142,7 +142,7 @@ def self.apply_header(hpxml_header, epw_file) | |||
end | |||
|
|||
if hpxml_header.temperature_capacitance_multiplier.nil? | |||
hpxml_header.temperature_capacitance_multiplier = 1.0 | |||
hpxml_header.temperature_capacitance_multiplier = 7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recall I made a commit where we set this to 7.0 using the ResStockArguments measure; I don't think we need this change to hpxml_defaults.rb
.
…d that's why it was 1 in the first place, not because I was messing with TCM. Revert
Superseded by #1247. |
Pull Request Description
Closes: #1161
After discussion and recent investigations into better understanding the resilience impacts of the ResStock timeseries results for power outages and load-shifting events, there is some evidence that the amount of thermal mass in ResStock is under-predicted. A quick (although non-physical fix) is to increase the temperature capacitance multiplier. A recommended number of 7.0 has been suggested by @jmaguire1. There are multiple efforts currently trying to leverage ResStock in these applications. While work is being done to better figure out a better solution, a quick fix is implemented to get the results in the acceptable range.
See related discussion in the attached issue for more details.
Checklist
Not all may apply:
openstudio tasks.rb update_measures
has been run