Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Temperature Capacitance Multiplier to 7.0 #1223

Closed
wants to merge 11 commits into from

Conversation

afontani
Copy link
Contributor

@afontani afontani commented Mar 26, 2024

Pull Request Description

Closes: #1161

After discussion and recent investigations into better understanding the resilience impacts of the ResStock timeseries results for power outages and load-shifting events, there is some evidence that the amount of thermal mass in ResStock is under-predicted. A quick (although non-physical fix) is to increase the temperature capacitance multiplier. A recommended number of 7.0 has been suggested by @jmaguire1. There are multiple efforts currently trying to leverage ResStock in these applications. While work is being done to better figure out a better solution, a quick fix is implemented to get the results in the acceptable range.

See related discussion in the attached issue for more details.

Checklist

Not all may apply:

  • Tests (and test files) have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI (checked comparison artifacts)

@afontani afontani requested a review from jmaguire1 March 26, 2024 22:10
@afontani afontani self-assigned this Mar 26, 2024
@afontani afontani linked an issue Mar 26, 2024 that may be closed by this pull request
Comment on lines 145 to 147
# Different than HPXML defaults, based on work from Jeff Maguire and Yueyue
# Discussion located in issue 1161 and will likely need to get updated later.
hpxml_header.temperature_capacitance_multiplier = 7.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI there is a BuildResHPXML measure argument for this: https://github.com/NREL/OpenStudio-HPXML/blob/master/BuildResidentialHPXML/measure.rb#L114-L117.

We could either control it using the yml file (requires bsb updates) or using the options lookup (like simulation_control_daylight_saving_enabled).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joseph-robertson : Thanks, I like the options_lookup suggestion. Are you able to revert this and then stub it out in options_lookup. This way it will be easy to change the value and when we all decide as a group what value to use, then we can switch it back to auto.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the change to hpxml-measures. Instead, I'm just setting capacitance=7.0 in ResStockArguments (assuming 7.0 for all datapoints).

Copy link
Contributor

@jmaguire1 jmaguire1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's pretty much how I would have done it, looks good! Still investigating the exact number we should use but 7 is better than 1 for sure.

@afontani
Copy link
Contributor Author

A couple screenshots from the datapoint comparisons...
Screenshot 2024-03-29 at 10 59 35 AM
Screenshot 2024-03-29 at 11 00 32 AM
Screenshot 2024-03-29 at 11 02 27 AM
Screenshot 2024-03-29 at 11 02 52 AM
Screenshot 2024-03-29 at 11 03 32 AM

jmaguire1 and others added 5 commits April 4, 2024 16:53
…an regenerate the artifact plots and look at the new unmet hours. Hopefully this leads to a lot less discrepancy in unmet hours?
@@ -142,7 +142,7 @@ def self.apply_header(hpxml_header, epw_file)
end

if hpxml_header.temperature_capacitance_multiplier.nil?
hpxml_header.temperature_capacitance_multiplier = 1.0
hpxml_header.temperature_capacitance_multiplier = 7.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recall I made a commit where we set this to 7.0 using the ResStockArguments measure; I don't think we need this change to hpxml_defaults.rb.

…d that's why it was 1 in the first place, not because I was messing with TCM. Revert
@joseph-robertson
Copy link
Contributor

Superseded by #1247.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temperature Capacitance Multiplier default values
3 participants