Ignore includes in v3->v4 conversions #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misi9170
approved these changes
May 8, 2024
|
|
||
| # Open the output file and loop through line by line | ||
| # if a line contains the substring !include, then strip all | ||
| # occurrences of ' from the line |
There was a problem hiding this comment.
This comment could perhaps state that the yaml load / dump sequence adds the string marks ' ' to the !include statements, which then need to be removed from the final output file. I didn't follow that at first. Otherwise, this looks great!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore includes in v3->v4 conversions
Currently when you convert an input yaml from v3 -> v4 using the converter script, any !include statements to turbine files get unpacked within the yaml file and then dumped into the file. While this can work, it means that the yaml file can get quite long if there were a number of turbines listed, and also the yaml is no longer tied to the turbine file, and changes made to the turbine file will have to be made to each instance within the yaml.
This pull pull request modifies the yaml load/dump routines within the converter to pass through those include statements directly. It further updates the convert script test to confirm the new methods are working. Previously, to avoid this issue a sentinal "XXXXX" string was used but this can now go back to the turbine yaml name