[BUGFIX] Incorrect indexing to hub heights in Farm.coordinates()
#890
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#846 introduced a bugfix to the
Farm.coordinates()
method, which was released and runs as expected in FLORIS v3.6. However, when develop was merged back into the v4 branch in preparation for the release of FLORIS v4.0, this line was missed in reducing from 5D to 4D data structures.This PR fixes this issue by simply removing the now-redundant dimension in accessing
hub_heights
.The following code demonstrates the error that is raised:
With the bugfix, this produces
as expected. Prior to the bug fix (on the develop branch), the output is:
Thank you to @AJP-47 for identifying this bug in #887, and to @rafmudaf for helping track it down.