Add landbosse #18
Add landbosse #18
Conversation
|
@RHammond2 can you take a look when you get a chance |
There was a problem hiding this comment.
@crookp, I left a handful of minor comments, but I think this is pretty close to ready to merge. Once LandBOSSE gets that next release, can you also pin that version as the minimum in the pyproject.toml? After these few things, this PR should be good to go.
| # TODO TEMP | ||
| import sys | ||
| sys.path.append(str(Path("./../LandBOSSE").resolve())) |
There was a problem hiding this comment.
Is this still temporary? Or are we essentially waiting to release the next minor/patch version of landbosse for this to be complete?
| if TYPE_CHECKING: | ||
| assert isinstance(self.weather, pd.DataFrame) # mypy helper | ||
| weather = self.weather.loc[self.operations_start : self.operations_end] | ||
|
|
There was a problem hiding this comment.
Thanks for simplifying this block!
| @@ -1539,7 +1746,7 @@ def technical_loss_ratio(self) -> float: | |||
| elif self.turbine_type == "fixed": | |||
| return 0.01 | |||
| else: | |||
| raise NotImplementedError("land-based is not currently modeled") | |||
| return 0.0 | |||
There was a problem hiding this comment.
I see here and for electrical losses that these are 0, is that coming from landbosse/COWER, or do we just not have a good source yet?
Adds the option to call either LandBOSSE or ORBIT to calculate CAPEX using a new basic API for LandBOSSE. This includes adding the outputs from LandBOSSE to the output metrics.
running LandBOSSE requires an input yaml file to specify configurations, and an input excel file that contains tabular inputs
Also includes some checks before running any models that ensure inputs that are shared between models (e.g. number of turbines) are consistent.