EnergyPlus v24.2.0: add model and FT tests #5265

joseph-robertson · 2024-10-03T04:16:22Z

Pull request overview

Checklist:

Model
- SizingZone
- ChillerElectricEIR
- ChillerElectricReformulatedEIR
- Site
FT
- SizingZone
- ChillerElectricEIR
- ChillerElectricReformulatedEIR
- Site

Pull Request Author

Model API Changes / Additions
Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
Model API methods are tested (in src/model/test)
EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
All new and existing tests passes
If methods have been deprecated, update rest of code to use the new methods

Labels:

If change to an IDD file, add the label IDDChange
If breaking existing API, add the label APIChange
If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

Perform a Code Review on GitHub
Code Style, strip trailing whitespace, etc.
All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
Labeling is ok
If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
If feature, test running new feature, try creative ways to break it
CI status: all green or justified

…hillers fixup 60bae94

Add Getters/Setters and fuelTypes test for the CHillers (they didn't have one), remove harcoding in Ctor when the IDD has a default with the same value. Implement a missing validXXXValues method for the Reformulated one

cf #5242 (review)

…yLTSetpointNode fails ``` Value of: ch.setHeatRecoveryLeavingTemperatureSetpointNode(hwLoop.supplyOutletNode()) Actual: false Expected: true ```

….0-tests

ci-commercialbuildings · 2024-10-03T18:14:51Z

CI Results for 1fb339a:

Ubuntu 20.04:
Ubuntu 22.04:
- OpenStudio-3.9.0-alpha+1fb339a40b-Ubuntu-22.04-x86_64.deb
- OpenStudio-3.9.0-alpha+1fb339a40b-Ubuntu-22.04-x86_64.tar.gz
Darwin:
Windows:
Code Coverage:

jmarrec · 2024-10-04T09:06:52Z

src/energyplus/Test/Site_GTest.cpp

@@ -49,6 +49,6 @@ TEST_F(EnergyPlusFixture, ForwardTranslator_Site) {
  EXPECT_EQ(0.0, idf_site.getDouble(Site_LocationFields::Longitude).get());
  EXPECT_EQ(0.0, idf_site.getDouble(Site_LocationFields::TimeZone).get());
  EXPECT_EQ(0.0, idf_site.getDouble(Site_LocationFields::Elevation).get());
-  EXPECT_EQ("Suburbs", idf_site.getString(Site_LocationFields::Terrain).get());
+  // EXPECT_EQ("Suburbs", idf_site.getString(Site_LocationFields::Terrain).get()); not in FT


Terrain is on the Building Objects, should test for that

The comment here is confusing.

But at least this is already tested here:

OpenStudio/src/energyplus/Test/Building_GTest.cpp

Lines 97 to 124 in ba1b94b

Building building = model.getUniqueModelObject<Building>();

building.setName("Building");

building.setNorthAxis(20);

building.setNominalFloortoFloorHeight(5);

Site site = model.getUniqueModelObject<Site>();

site.setTerrain("Ocean");

auto simulationControl = model.getUniqueModelObject<SimulationControl>();

simulationControl.setLoadsConvergenceToleranceValue(0.2);

simulationControl.setTemperatureConvergenceToleranceValue(0.2);

simulationControl.setSolarDistribution("FullInteriorAndExteriorWithReflections");

simulationControl.setMaximumNumberofWarmupDays(2);

ForwardTranslator forwardTranslator;

Workspace workspace = forwardTranslator.translateModel(model);

ASSERT_EQ(1u, workspace.getObjectsByType(IddObjectType::Building).size());

ASSERT_EQ(1u, workspace.getObjectsByType(IddObjectType::Site_Location).size());

ASSERT_EQ(1u, workspace.getObjectsByType(IddObjectType::SimulationControl).size());

WorkspaceObject object = workspace.getObjectsByType(IddObjectType::Building)[0];

ASSERT_TRUE(object.getString(BuildingFields::Name));

EXPECT_EQ("Building", object.getString(BuildingFields::Name).get());

ASSERT_TRUE(object.getDouble(BuildingFields::NorthAxis));

EXPECT_EQ(20, object.getDouble(BuildingFields::NorthAxis).get());

ASSERT_TRUE(object.getString(BuildingFields::Terrain));

EXPECT_EQ("Ocean", object.getString(BuildingFields::Terrain).get());

Add model and ft tests for new SizingZone field.

f6b75a4

joseph-robertson added the Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. label Oct 3, 2024

joseph-robertson self-assigned this Oct 3, 2024

joseph-robertson mentioned this pull request Oct 3, 2024

Update to EnergyPlus v24.2.0a #5242

Merged

19 tasks

joseph-robertson and others added 4 commits October 3, 2024 12:13

Add model and ft tests for new SizingZone field.

60520c1

Change getter to double and remove reset for now-required-fields in C…

3f564f5

…hillers fixup 60bae94

Add Getters/Setters and fuelTypes test for the CHillers

538fcbe

Add Getters/Setters and fuelTypes test for the CHillers (they didn't have one), remove harcoding in Ctor when the IDD has a default with the same value. Implement a missing validXXXValues method for the Reformulated one

Strip trailing spaces in IDDs

9a116f0

jmarrec self-assigned this Oct 3, 2024

jmarrec force-pushed the v24.2.0-tests branch from f6b75a4 to 9a116f0 Compare October 3, 2024 13:13

jmarrec added 6 commits October 3, 2024 15:25

Add site Gtest

25612d7

Remove isSizingOptionDefailted and resetter now that it's required-field

9529bfe

Fixup children and ScheduleRegistry for Chiller Objects

b67ec50

cf #5242 (review)

Add a full FT test for CHillerElectricEIR (wasn't present)

163c3b8

Add a full FT test for ChillerElectricReformulatedEIR. setHeatRecover…

0840089

…yLTSetpointNode fails ``` Value of: ch.setHeatRecoveryLeavingTemperatureSetpointNode(hwLoop.supplyOutletNode()) Actual: false Expected: true ```

Correct the ReformulatedEIR Leaving Setpoint Node field

813ed66

jmarrec force-pushed the v24.2.0-tests branch from b849e04 to 813ed66 Compare October 3, 2024 14:52

jmarrec and others added 5 commits October 3, 2024 17:07

Add Node convenience getters for ChillerEIRs

576b537

Merge branch 'v24.2.0-tests' of github.com:NREL/OpenStudio into v24.2…

e8d87e6

….0-tests

Add a full FT test for Site (wasn't present).

9c8cdd0

Use correct site fields.

85d43f6

Site terrain is not included in FT.

1fb339a

joseph-robertson marked this pull request as ready for review October 3, 2024 18:19

joseph-robertson merged commit a984d95 into v24.2.0-IOFreeze Oct 3, 2024
0 of 4 checks passed

joseph-robertson deleted the v24.2.0-tests branch October 3, 2024 18:20

jmarrec reviewed Oct 4, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EnergyPlus v24.2.0: add model and FT tests #5265

EnergyPlus v24.2.0: add model and FT tests #5265

joseph-robertson commented Oct 3, 2024 •

edited

Loading

ci-commercialbuildings commented Oct 3, 2024 •

edited

Loading

jmarrec Oct 4, 2024

jmarrec Oct 4, 2024

	Building building = model.getUniqueModelObject<Building>();
	building.setName("Building");
	building.setNorthAxis(20);
	building.setNominalFloortoFloorHeight(5);

	Site site = model.getUniqueModelObject<Site>();
	site.setTerrain("Ocean");

	auto simulationControl = model.getUniqueModelObject<SimulationControl>();
	simulationControl.setLoadsConvergenceToleranceValue(0.2);
	simulationControl.setTemperatureConvergenceToleranceValue(0.2);
	simulationControl.setSolarDistribution("FullInteriorAndExteriorWithReflections");
	simulationControl.setMaximumNumberofWarmupDays(2);

	ForwardTranslator forwardTranslator;
	Workspace workspace = forwardTranslator.translateModel(model);

	ASSERT_EQ(1u, workspace.getObjectsByType(IddObjectType::Building).size());
	ASSERT_EQ(1u, workspace.getObjectsByType(IddObjectType::Site_Location).size());
	ASSERT_EQ(1u, workspace.getObjectsByType(IddObjectType::SimulationControl).size());

	WorkspaceObject object = workspace.getObjectsByType(IddObjectType::Building)[0];
	ASSERT_TRUE(object.getString(BuildingFields::Name));
	EXPECT_EQ("Building", object.getString(BuildingFields::Name).get());
	ASSERT_TRUE(object.getDouble(BuildingFields::NorthAxis));
	EXPECT_EQ(20, object.getDouble(BuildingFields::NorthAxis).get());
	ASSERT_TRUE(object.getString(BuildingFields::Terrain));
	EXPECT_EQ("Ocean", object.getString(BuildingFields::Terrain).get());

EnergyPlus v24.2.0: add model and FT tests #5265

EnergyPlus v24.2.0: add model and FT tests #5265

Conversation

joseph-robertson commented Oct 3, 2024 • edited Loading

Pull request overview

Pull Request Author

Review Checklist

ci-commercialbuildings commented Oct 3, 2024 • edited Loading

jmarrec Oct 4, 2024

Choose a reason for hiding this comment

jmarrec Oct 4, 2024

Choose a reason for hiding this comment

joseph-robertson commented Oct 3, 2024 •

edited

Loading

ci-commercialbuildings commented Oct 3, 2024 •

edited

Loading