gbXML 7.03

[MatthewSteen]

Pull request overview

WIP to deliver a custom build to Autodesk prior to inclusion in a major release.

Close #4966.

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[jmarrec]

I fixed the newline situation in the schema, and made sure CI picked up on it.

[ci-commercialbuildings]

CI Results for 72b4137:

• Ubuntu 20.04:

  • OpenStudio-3.6.0+72b4137138-Ubuntu-20.04-x86_64.deb
  • OpenStudio-3.6.0+72b4137138-Ubuntu-20.04-x86_64.tar.gz
  • perf_test/results.html

• Ubuntu 22.04:

  • OpenStudio-3.6.0+72b4137138-Ubuntu-22.04-x86_64.deb
  • OpenStudio-3.6.0+72b4137138-Ubuntu-22.04-x86_64.tar.gz

• Darwin:

  • OpenStudio-3.6.0+72b4137138-Darwin-x86_64.dmg
  • OpenStudio-3.6.0+72b4137138-Darwin-x86_64.tar.gz

• Windows:

  • OpenStudio-3.6.0+72b4137138-Windows.exe
  • OpenStudio-3.6.0+72b4137138-Windows.tar.gz

• Code Coverage:

[DavidGoldwasser]

@MatthewSteen are there any new gbXML test files that we need to add. I wasn't sure if there are new objects in this, that would require work on forward or reverse translation, or if things should work without upgrades to those?

[MatthewSteen]

I fixed the newline situation in the schema, and made sure CI picked up on it.

Thanks!

[MatthewSteen]

@MatthewSteen are there any new gbXML test files that we need to add. I wasn't sure if there are new objects in this, that would require work on forward or reverse translation, or if things should work without upgrades to those?

@DavidGoldwasser I'm in the process of updating the gbxml-to-openstudio repo with 7.03 gbxml files and measure updates. See NREL/gbxml-to-openstudio#129. So far, I haven't come across any issues with this OpenStudio build running the measures on the gbxmls.

• Changelog = https://www.gbxml.org/Schema_Current_GreenBuildingXML_gbXML

[MatthewSteen]

@joseph-robertson this was mostly a selfish PR to get a custom build of OS with the new gbXML version for my Autodesk project. Happy to continue working on it or have someone else take it from here.

[jmarrec]

Superseded by #4995