Fix #4909 - Update license to new format #4910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrec
added
component - Workflow
Pull Request - Ready for CI
jmarrec
commented
Jun 6, 2023
Comment on lines
+10
to
+19
| ROOT_DIR = File.absolute_path(File.join(File.dirname(__FILE__), "../../")) | ||
| LICENSE_PATH = File.join(ROOT_DIR, 'LICENSE.md') | ||
|
|
||
|
|
||
| license_lines = File.readlines(LICENSE_PATH) | ||
| # Now with short version | ||
| license_lines = [ | ||
| "OpenStudio(R), Copyright (c) Alliance for Sustainable Energy, LLC.\n", | ||
| "See also https://openstudio.net/license\n" | ||
| ] |
There was a problem hiding this comment.
New short license here. Shouldn't change.
the https://openstudio.net/license is a dead link currently though
Comment on lines
+40
to
+51
| exceptions = [ | ||
| File.join(ROOT_DIR, "ci"), | ||
| File.join(ROOT_DIR, "developer"), | ||
| File.join(ROOT_DIR, "src/nano/"), | ||
| File.join(ROOT_DIR, "src/polypartition/"), | ||
| "mainpage.hpp", | ||
| "empty.hpp" | ||
| ] | ||
|
|
||
| # glob for hpp and cpp | ||
| files = Dir.glob(basepath + "/src/**/*.[ch]pp") | ||
| files.concat Dir.glob(basepath + "/ruby/**/*.[ch]pp") | ||
| files.concat Dir.glob(basepath + "/src/**/*.cxx.in") | ||
| files.concat Dir.glob(basepath + "/src/**/*.tmp") | ||
| files = Dir.glob(File.join(ROOT_DIR, "**/*.[ch]pp")) | ||
| files += Dir.glob(File.join(ROOT_DIR, "**/*.[ch]xx.in")) |
There was a problem hiding this comment.
Clean up the code a bit to match the new structure. I'm grabbing files and folder that were excluded before (like the python/ one). I'm also adding license to python/**/*.py too
LICENSE.md
Outdated
copyright.txt
Outdated
There was a problem hiding this comment.
And here (also got the latest E+ license from github)
`ruby developer/ruby/ApplyCopyright.rb`
|
CI Results for 7662d79:
|
|
@jmarrec This is great. Going to make the copyright maintenance so much easier. |
tijcolem
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.