We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@shorowit reported this change of behavior between 3.6.1 and 3.7.0-alpha. This used to work in 3.6.1, and now the copy constructor isn't swigg'ed.
[6] 3_7_0(main)> OpenStudio::Point3d.new(OpenStudio::Point3d.new(0, 0, 0)) ArgumentError: Wrong arguments for overloaded method 'Point3d.new'. Possible C/C++ prototypes are: Point3d.new() Point3d.new(double x, double y, double z) from (pry):6:in `initialize' [7] 3_7_0(main)> OpenStudio::Vector3d.new(OpenStudio::Vector3d.new(0, 0, 0)) ArgumentError: Wrong arguments for overloaded method 'Vector3d.new'. Possible C/C++ prototypes are: Vector3d.new() Vector3d.new(double x, double y, double z)
This is due to this commit of mine, where I applied Rule of 1 in the C++ code, not realizing that this had an impact on SWIG: 565bea0#diff-9ef35a3df57f646ab394775dab1b9d3212fd52c1d5bbce281c2585c6df05a952
For these geometry classes, it's probably a good idea to ensure that the copy ctor is swigged.
Some additional details about your environment for this issue (if relevant):
https://github.com/NREL/OpenStudio-HPXML/blob/5e218b5d148effc86f12cbdeb682c21fe8a63db1/BuildResidentialHPXML/resources/geometry.rb#L2360
length = OpenStudio::Vector3d.new(point_one - point_two).length
The text was updated successfully, but these errors were encountered:
Fix #4957 - Put back the copy ctor for SWIG for Point3d, Vector3d, Pl…
2cdc9c2
…ane and Transformation
Merge pull request #4960 from NREL/4957_Swig_CopyCtors
b68aa0a
#4957 - Some copy constructors aren't declared in SWIG
jmarrec
Successfully merging a pull request may close this issue.
Issue overview
@shorowit reported this change of behavior between 3.6.1 and 3.7.0-alpha. This used to work in 3.6.1, and now the copy constructor isn't swigg'ed.
Possible Solution
This is due to this commit of mine, where I applied Rule of 1 in the C++ code, not realizing that this had an impact on SWIG: 565bea0#diff-9ef35a3df57f646ab394775dab1b9d3212fd52c1d5bbce281c2585c6df05a952
For these geometry classes, it's probably a good idea to ensure that the copy ctor is swigged.
Details
Environment
Some additional details about your environment for this issue (if relevant):
Context
https://github.com/NREL/OpenStudio-HPXML/blob/5e218b5d148effc86f12cbdeb682c21fe8a63db1/BuildResidentialHPXML/resources/geometry.rb#L2360
The text was updated successfully, but these errors were encountered: