EpwFile .getTimeSeries method fails if the weather file represents a leap year

[mdahlhausen]

Steps to recreate bug:

1. get a weather file with a leap year (Feb 29)
2. Run:

weather_file = 'path/to/weather_file.epw'
epw = OpenStudio::EpwFile.new(weather_file)
epw.getTimeSeries('Dry Bulb Temperature')

Error:

[utilities.time.Date] <2> Bad Date: year = 2009, month = Feb(2), day = 29. 
C:/Users/mdahlhau/Desktop/EULP/analyze_weather.rb:17:in `getTimeSeries': C:\Users\jenkins\git\OpenStudio\openstudiocore\src\utilities\time\Date.cpp@446 : Bad Date: year = 2009, month = Feb(2), day = 29.  (RuntimeError)

[jmarrec]

EpwDataPoint doesn't include the year in its date() method (while it does store it correctly):

OpenStudio/openstudiocore/src/utilities/filetypes/EpwFile.cpp

Line 1645 in a144928

return Date(MonthOfYear(m_month), m_day); // , m_year);

---

Unrelated: found a couple of typos while investigating this:

OpenStudio/openstudiocore/src/utilities/filetypes/EpwFile.cpp

Line 4596 in a144928

int year = std::stoi(split[1]);

OpenStudio/openstudiocore/src/utilities/filetypes/EpwFile.cpp

Line 4617 in a144928

int year = std::stoi(split[1]);

[jmarrec]

@mdahlhausen If you need a workaround immediately:

# id = OpenStudio::EpwDataField.new("Dry Bulb Temperature")
# units = OpenStudio::EpwDataPoint::getUnits(id)
units = 'C'
dates = OpenStudio::DateTimeVector.new()
values = []

epw.data.each do |pt|
  dates << OpenStudio::DateTime.new(OpenStudio::Date.new(OpenStudio::MonthOfYear.new(pt.month), pt.day, pt.year), pt.time)             
  values << pt.dryBulbTemperature.get
  # or
  # values << pt.getField(id).get
end  

t = OpenStudio::TimeSeries.new(dates, OpenStudio::createVector(values), units)

t.firstReportDateTime.to_s
=> "2012-Jan-01 01:00:00"

[mdahlhausen]

Thanks @jmarrec. I ended up just removing the leap year days from my weather files, but your method is more elegant.