Fix stochastic schedule generation runtime #1933
Merged
+185
−181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorowit
commented
Feb 17, 2025
| @schedules[SchedulesFile::Columns[:HotWaterFixtures].name] = fixtures.map { |flow| flow / fixtures.max } | ||
| @schedules[SchedulesFile::Columns[:HotWaterFixtures].name] = normalize(fixtures) |
There was a problem hiding this comment.
This is the primary bugfix. fixtures.max was being calculated within the iteration resulting in a huge performance hit.
Comment on lines
-779
to
+808
| discharging_schedule += [1] * first_half_driving # Start driving | ||
| discharging_schedule += [0] * idle_time # Idle in the middle | ||
| discharging_schedule += [1] * second_half_driving # End driving | ||
| charging_schedule += [0] * activity_minutes | ||
| discharging_schedule.concat([1] * first_half_driving) # Start driving | ||
| discharging_schedule.concat([0] * idle_time) # Idle in the middle | ||
| discharging_schedule.concat([1] * second_half_driving) # End driving | ||
| charging_schedule.concat([0] * activity_minutes) | ||
|
|
||
| driving_minutes_used += actual_driving_time | ||
| else | ||
| charging_schedule += [1] * activity_minutes | ||
| discharging_schedule += [0] * activity_minutes | ||
| charging_schedule.concat([1] * activity_minutes) | ||
| discharging_schedule.concat([0] * activity_minutes) |
There was a problem hiding this comment.
Specifically for EVs, this code was also resulting in some slowdown since += creates new arrays and all of this is happening within a loop.
Comment on lines
559
to
561
| hours_per_year = (vehicle.hours_per_week / 7) * UnitConversions.convert(1, 'yr', 'day') | ||
| hours_per_week = get_ev_hours_per_week(vehicle) |
There was a problem hiding this comment.
Found a bug while working on all of this. hours_per_week is not a required input, so we need to default it when not provided.
I should see if we can apply defaults to the entire HPXML Building (or a copy of the object, if we need to prevent writing the defaults out to disk) to generically prevent issues like this in the future...
…vidual defaulting methods. Should help prevent future bugs like vehicle.hours_per_week.
|
CI results:
I'm calling it good enough. |
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes a regression introduced here that resulted in very slow generation of stochastic schedules.
Checklist
Not all may apply:
EPvalidator.xml) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run