Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible glass block error #1927

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Fix possible glass block error #1927

merged 2 commits into from
Feb 11, 2025

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Feb 10, 2025 •
edited
Loading

Pull Request Description

Fixes #1926.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit self-assigned this Feb 10, 2025
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
1a3d1d9 
…o bugfix_glass_block

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
@shorowit shorowit requested a review from bpark1327 February 11, 2025 00:05
bpark1327
bpark1327 approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@bpark1327 bpark1327 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that the bug has been fixed. Thank you!

@shorowit shorowit merged commit 5c1f30d into master Feb 11, 2025
7 checks passed
@shorowit shorowit deleted the bugfix_glass_block branch February 11, 2025 14:44
@joseph-robertson joseph-robertson mentioned this pull request Feb 11, 2025
Merged
24 tasks
@willf willf mentioned this pull request Feb 12, 2025
Open
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpark1327 bpark1327 bpark1327 approved these changes

Assignees

@shorowit shorowit

Labels
None yet
Projects
OpenStudio-HPXML
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

possible error for glass block window
2 participants
@shorowit @bpark1327