Update NEEP ASHP sample files #1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorowit
commented
Feb 7, 2025
Comment on lines
+54
to
+59
| <extension> | ||
| <AdditionalProperties> | ||
| <HeatPump>YORK HMH7</HeatPump> | ||
| <HeatPumpAHRICert>208613158</HeatPumpAHRICert> | ||
| </AdditionalProperties> | ||
| </extension> |
There was a problem hiding this comment.
Added Names and AHRI#s so we can more easily look up these products in the NEEP database in the future.
Comment on lines
-354
to
+360
| <Value>4.47</Value> | ||
| <Value>4.57</Value> |
There was a problem hiding this comment.
Found a small typo when double-checking the numbers.
Comment on lines
-367
to
+373
| <Value>3.27</Value> | ||
| <Value>5.52</Value> |
There was a problem hiding this comment.
Found a not-so-small typo 😳
Comment on lines
+446
to
+447
| <PerformanceDataPoint> | ||
| <OutdoorTemperature>-5.0</OutdoorTemperature> |
There was a problem hiding this comment.
This NEEP product has data at -5F too, so I added it. (I also removed the base-hvac-air-to-air-heat-pump-var-speed-detailed-performance-other-temperatures.xml file, since we're now testing an additional temperature here).
yzhou601
approved these changes
Feb 7, 2025
24 tasks
20 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Updated sample files to correspond with current NEEP ccASHP listings. Will help with #1879.
Checklist
Not all may apply:
EPvalidator.xml) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run