-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HVAC Autosizing Limits #1584
HVAC Autosizing Limits #1584
Conversation
…ion system is supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty close, just a few things I noticed.
...low/sample_files/base-hvac-air-to-air-heat-pump-var-speed-backup-furnace-autosize-factor.xml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Just want to see that one last set of default test changes reverted and then this can merge in.
Pull Request Description
Closes #1530. Closes #1556. Supersedes #1547.
The PR aims to allow specifying upper limits for autosized capacities.
Adds optional arguments to BuildResidentialHPXML:
heating_system_heating_autosizing_limit
cooling_system_cooling_autosizing_limit
heat_pump_heating_autosizing_limit
heat_pump_cooling_autosizing_limit
heat_pump_backup_heating_autosizing_limit
heating_system_2_heating_autosizing_limit
hvac_blower_fan_watts_per_cfm
Update sample files:
base-hvac-central-ac-only-1-speed-autosize-factor.xml
base-hvac-furnace-gas-room-ac-autosize-factor.xml
base-hvac-air-to-air-heat-pump-1-speed-autosize-factor.xml
base-hvac-air-to-air-var-speed-backup-furnace-autosize-factor.xml
base-hvac-mini-split-heat-pump-ductless-autosize-factor.xml
Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
EPvalidator.xml
) has been updatedopenstudio tasks.rb update_hpxmls
)HPXMLtoOpenStudio/tests/test*.rb
and/orworkflow/tests/test*.rb
)openstudio tasks.rb update_measures
has been run