Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HVAC Autosizing Limits #1584

Merged
merged 135 commits into from
Apr 29, 2024
Merged

HVAC Autosizing Limits #1584

merged 135 commits into from
Apr 29, 2024

Conversation

joseph-robertson
Copy link
Collaborator

@joseph-robertson joseph-robertson commented Jan 4, 2024

Pull Request Description

Closes #1530. Closes #1556. Supersedes #1547.

The PR aims to allow specifying upper limits for autosized capacities.

Adds optional arguments to BuildResidentialHPXML:

  • heating_system_heating_autosizing_limit
  • cooling_system_cooling_autosizing_limit
  • heat_pump_heating_autosizing_limit
  • heat_pump_cooling_autosizing_limit
  • heat_pump_backup_heating_autosizing_limit
  • heating_system_2_heating_autosizing_limit
  • hvac_blower_fan_watts_per_cfm

Update sample files:

  • base-hvac-central-ac-only-1-speed-autosize-factor.xml
  • base-hvac-furnace-gas-room-ac-autosize-factor.xml
  • base-hvac-air-to-air-heat-pump-1-speed-autosize-factor.xml
  • base-hvac-air-to-air-var-speed-backup-furnace-autosize-factor.xml
  • base-hvac-mini-split-heat-pump-ductless-autosize-factor.xml

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

joseph-robertson and others added 30 commits October 27, 2023 14:19
@joseph-robertson joseph-robertson changed the title HVAC air distribution control HVAC Autosizing Limits Apr 25, 2024
@joseph-robertson joseph-robertson added this to the 1.8.0 milestone Apr 25, 2024
Copy link
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty close, just a few things I noticed.

Copy link
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Just want to see that one last set of default test changes reverted and then this can merge in.

@shorowit shorowit merged commit ccd3e57 into master Apr 29, 2024
7 checks passed
@shorowit shorowit deleted the max-airflow-args2 branch April 29, 2024 21:39
@joseph-robertson joseph-robertson mentioned this pull request Apr 30, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Sizing control option to specify max allowed airflow Expose blower W/cfm
3 participants