Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BACnet Scan Documentation for BuildingMOTIF CLI #280

Merged
merged 3 commits into from
Sep 15, 2023
Merged

BACnet Scan Documentation for BuildingMOTIF CLI #280

merged 3 commits into from
Sep 15, 2023

Conversation

TShapinsky
Copy link
Member

Fixes #268

@TShapinsky TShapinsky added the documentation Improvements or additions to documentation label Sep 11, 2023
gtfierro
gtfierro approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@gtfierro gtfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

MatthewSteen
MatthewSteen reviewed Sep 13, 2023
View reviewed changes
Copy link
Member

@MatthewSteen MatthewSteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple suggestions to consider.

TShapinsky and others added 2 commits September 14, 2023 13:44
@TShapinsky @MatthewSteen
Update docs/reference/cli_tool.md
e5b5cda 
Co-authored-by: Matt Steen <MatthewSteen@users.noreply.github.com>
@TShapinsky @MatthewSteen
Update docs/reference/cli_tool.md
ff85af7 
Co-authored-by: Matt Steen <MatthewSteen@users.noreply.github.com>
@MatthewSteen MatthewSteen merged commit 28f20c6 into develop Sep 15, 2023
@MatthewSteen MatthewSteen deleted the bacnet_cli_documentation branch September 15, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtfierro gtfierro gtfierro approved these changes

@MatthewSteen MatthewSteen MatthewSteen approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bacnet CLI Doc Section
3 participants
@TShapinsky @gtfierro @MatthewSteen