Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dependencies easier to manage for development #264

Merged
merged 7 commits into from
Jul 1, 2023

Conversation

gtfierro
Copy link
Collaborator

  • the "extra" dependencies were not actually marked as optional, so they were all being installed anyway. This commit makes sure they are not installed unless the developer wants them to (by including them in the dev dependency group)
  • "psycopg2" can be difficult to install on some systems like MacOS due to needing to tell the installation process about the location of the libpq library. Now, the much easier "psycopg2-binary" package will be installed as part of the development dependencies. To use postgres in production, one will need to install buildingMOTIF with the "postgres" option/flag which will install the "psycopg2" library which is recommended over "psycopg2-binary" for production

@haneslinger the second bullet above should make the BuildingMOTIF easier for our intern to install

@TShapinsky and @MatthewSteen let me know if you have any other ideas on how this could be done. I've updated the docs to reflect this setup

gtfierro added 3 commits June 17, 2023 14:38
- the "extra" dependencies were not actually marked as optional, so they
  were all being installed anyway. This make sure they are not installed
  unless the developer wants them to
- "psycopg2" can be difficult to install on some systems like MacOS due
  to needing to tell the installation process about the location of the
  libpq library. Now, the much easier "psycopg2-binary" package will be
  installed as part of the development dependencies. To use postgres in
  production, one will need to install buildingMOTIF with the "postgres"
  option/flag which will install the "psycopg2" library which is
  recommended over "psycopg2-binary" for production.
Copy link
Member

@TShapinsky TShapinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, one typo. This approach seems to align with general guidance about psycopg2

gtfierro and others added 2 commits June 29, 2023 13:30
Co-authored-by: Tobias Shapinsky <tobiasshapinsky@gmail.com>
@gtfierro gtfierro merged commit 730d6b8 into develop Jul 1, 2023
@gtfierro gtfierro deleted the gtf-handle-extra-dependencies branch July 1, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants