Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable repo-visualizer #235

Merged
merged 1 commit into from
Mar 24, 2023
Merged

disable repo-visualizer #235

merged 1 commit into from
Mar 24, 2023

Conversation

MatthewSteen
Copy link
Member

@MatthewSteen MatthewSteen commented Mar 24, 2023 •
edited
Loading

Close #234.

example: https://github.com/NREL/BuildingMOTIF/actions/runs/4494399949/jobs/7906838362
We either have to 1. override the branch protections somehow or 2. skip this step on protected branches.

Suggest revisiting later. See https://github.com/githubocto/repo-visualizer/issues/29.

@MatthewSteen MatthewSteen self-assigned this Mar 24, 2023
@MatthewSteen MatthewSteen added the documentation Improvements or additions to documentation label Mar 24, 2023
haneslinger
haneslinger approved these changes Mar 24, 2023
View reviewed changes
Copy link
Collaborator

@haneslinger haneslinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Could you add a quick comment to remind us why we took in out?

@MatthewSteen MatthewSteen merged commit 6556fe5 into develop Mar 24, 2023
@MatthewSteen MatthewSteen deleted the disable-repo-vis branch March 24, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haneslinger haneslinger haneslinger approved these changes

Assignees

@MatthewSteen MatthewSteen

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The action deploy-docs repo-visualizer always fails on protected branches.
2 participants
@MatthewSteen @haneslinger