Override steps as epoch in Mlflow logger #583
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, there is a heated debate in the PytorchLightning community on the appropriate behavior of logging
onStep=False
andonEpoch=True
metrics. These metrics will be logged with based on the global step unit for the x-axis, which complicates the data analysis when using a logger such as mlflow to interpret metrics. The goal of this PR is to implement a workaround found by the community to override the step metrics so it is based on epochs instead, allowing a better understanding of the behavior of the model, regardless of batchsize.here is the original issue
Type of change
What types of changes does your code introduce? Put an
x
in all the boxes that apply:How Has This Been Tested?
If the added changes are already cover by tests, skip that section.
Otherwise, please describe tests that you added to the pytest codebase (if applicable).
this was tested locally on a different model, but should work correctly on the others too
Screenshots (if applicable):
Checklist:
If you're unsure about any of these, don't hesitate to ask. We're here to help!
If your PR does not fulfill all of the requirements in the checklist above, that's OK! If you need help, @-mention a maintainer and/or add the Status: Help Needed label.