565 feature geo inference integration #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 27 commits
April 17, 2024 17:36
…into geo-inference
…rning into 565-feature-geo-inference-integration
CharlesAuthier
previously approved these changes
Jun 12, 2024
…ents and improve logging
valhassan
requested review from
CharlesAuthier,
remtav,
mpelchat04,
LucaRom and
ms888ekb
LucaRom
reviewed
Jul 9, 2024
ms888ekb
reviewed
Jul 10, 2024
| uses: actions/checkout@v4.1.2 | ||
|
|
||
| - name: create environment | ||
| uses: conda-incubator/setup-miniconda@v3 |
evaluate_segmentation.py
Outdated
| @@ -124,7 +124,9 @@ def main(params): | |||
| gpkg_name_ = [] | |||
|
|
|||
| for aoi in tqdm(list_aois, desc='Evaluating from input list', position=0, leave=True): | |||
| output_path = working_folder / f"{aoi.aoi_id}_pred.tif" if not inference_image else inference_image | |||
| print(f"\nEvaluating AOI: {aoi.aoi_id}") | |||
There was a problem hiding this comment.
do we want to switch to logging,info() instead of print()?
There was a problem hiding this comment.
will take out the debug print statements. it's not meant to be there!
LucaRom
approved these changes
Jul 15, 2024
ms888ekb
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting your PR and helping us with GDL.
Please read the template below, fill it out as appropriate, and make additional changes to your code as needed.
Please feel free to submit your PR even if it doesn't satisfy all of the requirements below.
If you need assistance or review from a maintainer, add the label Status: Help Needed or Status: Review Needed respectively.
After review, a maintainer will add the label Status: Revision Needed if further work is required for the PR to be merged.
Description
This PR fully impacts inference_segmentation module in geo-deep-learning. Refer to the issue for more details.
Fixes #565 and #537
Type of change
What types of changes does your code introduce? Put an
xin all the boxes that apply:How Has This Been Tested?
A shakedown test for inference_srgmentation has been added to this PR.
Screenshots (if applicable):
Checklist:
If you're unsure about any of these, don't hesitate to ask. We're here to help!
If your PR does not fulfill all of the requirements in the checklist above, that's OK! If you need help, @-mention a maintainer and/or add the Status: Help Needed label.