[1pt] PR: Update PR template #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarsonPruitt-NOAA
added
the
documentation
mluck
reviewed
Mar 24, 2023
BradfordBates-NOAA
changed the title
|
@mluck thanks for your review and suggestions. I appreciate it. I addressed each one. Please let me know if you'd like to see modifications to the checklist, after the updates I made. |
mluck
previously approved these changes
Mar 28, 2023
|
Thanks, Rob. Nice work. This is a big improvement WRT standardizing our process. I agree with Matt's comment about adding "PR:" to title of this Pull Request. |
|
Looks like there are unresolved conflicts in the Changelog |
BradfordBates-NOAA
previously approved these changes
Mar 28, 2023
CarsonPruitt-NOAA
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple update to the
PULL_REQUEST_TEMPLATE.mdto remove unnecessary/outdated boilerplate items, add octothorpe (#) in front of Additions, Changes, Removals to mirror CHANGELOG.md format, and clean up the PR Checklist.Changes
docs/PULL_REQUEST_TEMPLATE.md- Update template to match CHANGELOG formatting, improve checklist to be applicableTesting
n/a
Checklist
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[_pt] PR: <description>devbranch (the default branch), you have a descriptive Feature Branch name using the format:dev-<description-of-change>(ie:dev-revise-levee-masking)devbranch/foss_fim/, run:pytest unit_tests/)