[1pt] PR: Remove other folder from test_cases
#779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After this gets merged.. the test_cases/other folder can be removed? (nothing needs to be copied out?) |
Yes, |
…inundation-mapping into dev-cleanup-test_cases
BradfordBates-NOAA
approved these changes
Dec 30, 2022
|
Merged. @RobHanna-NOAA please go ahead and remove directories as discussed in comments above. |
|
Yes, thank you. I will leave them there for a while for testing against older versions (and fim3), but put it on my list to remove later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes dependency on
otherfolder fromtest_cases. Also updates ESRI and QGIS symbology. Closes #775.Removals
tools/aggregate_metrics.pyandcache_metrics.py: Removes reference totest_cases/otherfolderChanges
config/symbology/esri/agreement_raster.lyrandqgis/agreement_raster.qml: Updates label fromWaterbody masktoMaskedsince mask also now includes levee-protected areastools/eval_alt_catfim.pyandrun_test_case.py: Updates waterbody mask to datasets located in/inputsfolderTesting
test_cases/otherand then rantools/synthesize_test_cases.py. Inundation produced correctly masked images.