Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1pt] PR: Clip WBD to 3DEP DEM domain #753

Merged
merged 7 commits into from
Dec 23, 2022
Merged

Conversation

mluck
Copy link
Contributor

@mluck mluck commented Dec 3, 2022

Creates a polygon of 3DEP DEM domain (to eliminate errors caused by stream networks with no DEM data in areas of HUCs that are outside of the U.S. border) and uses the polygon layer to clip the WBD and stream network (to a buffer inside the WBD). Addresses #748.

Additions

  • data/usgs/acquire_and_preprocess_3dep_dems.py: Adds creation of 3DEP domain polygon by polygonizing all HUC6 3DEP DEMs and then dissolving them.
  • src/gms/run_by_unit.sh: Adds 3DEP domain polygon .gpkg as input to src/clip_vectors_to_wbd.py

Changes

  • src/clip_vectors_to_wbd.py: Clips WBD to 3DEP domain polygon and clips streams to a buffer inside the clipped WBD polygon.

Testing

  1. Ran gms_run_unit.sh and gms_run_branch.sh on test HUCs 10060006, 04300109, 04100001 (specified in [8pt] US Border HUC branches are throwing error 61 #748) and 17010206.

Screenshots

Streams are clipped where the DEM data ends at the U.S. - Canada border
image

Streams are clipped to the buffer within the WBD
image

Notes

  • This does not resolve the Exit status: 1 for HUC 04100001 (branch 1316000004, catchment in purple) which is caused by an unrelated issue

image

Todos

  • Parallelize the HUC6 polygons creation: the current serialized procedure takes approximately 12 hours to create the 3DEP DEM domain polygon (but this only needs to be created if the DEM data change).

@mluck mluck added bug Something isn't working FIM4 labels Dec 3, 2022
@mluck mluck self-assigned this Dec 3, 2022
@mluck mluck changed the title Clip to 3DEP DEM domain [1pt] PR: Clip to 3DEP DEM domain Dec 4, 2022
@mluck mluck changed the title [1pt] PR: Clip to 3DEP DEM domain [1pt] PR: Clip WBD to 3DEP DEM domain Dec 5, 2022
@RobHanna-NOAA RobHanna-NOAA linked an issue Dec 6, 2022 that may be closed by this pull request
@RobHanna-NOAA
Copy link
Contributor

New BED test, looked pretty good. One HUC failed outright (gms_run_unit) which is 010170104 and is a known issue.

95 branches failed of which 2 were exit status 1 and the other 93 were exit status 61. The two that were exit status of 1 are known issues. I spot checked some of the others they were for streams that are outside our stream buffer (which is 30 meters (3 * cellsize)) and that scenario is just fine. No further fix required.

RobHanna-NOAA
RobHanna-NOAA previously approved these changes Dec 19, 2022
@BradfordBates-NOAA BradfordBates-NOAA merged commit 0355e2c into dev Dec 23, 2022
@BradfordBates-NOAA BradfordBates-NOAA deleted the dev-3dep-domain branch December 23, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FIM4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[8pt] US Border HUC branches are throwing error 61
3 participants