Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9pt] PR: Cahaba Codebase Cleanup - Small Items #433

Merged
merged 51 commits into from
Aug 18, 2021
Merged

Conversation

nickchadwick-noaa
Copy link
Collaborator

The PR addresses issue #432

All changes in this PR are to better clean up and organize the repo, as well as removing any unused scripts, packages, and code.

@nickchadwick-noaa nickchadwick-noaa added refactoring Refacting code to obtain the same result dependencies Pull requests that update a dependency file labels Jul 2, 2021
@nickchadwick-noaa nickchadwick-noaa added this to the FIM v3.X milestone Jul 2, 2021
@nickchadwick-noaa nickchadwick-noaa self-assigned this Jul 2, 2021
@nickchadwick-noaa
Copy link
Collaborator Author

Currently testing this PR using Docker image foss-fim:dev-cleanup. Will post any issues I find.

@nickchadwick-noaa nickchadwick-noaa changed the title Cahaba Codebase Cleanup - Small Items [3pt] Cahaba Codebase Cleanup - Small Items Jul 2, 2021
@BradfordBates-NOAA
Copy link
Member

@nickchadwick-noaa Can you make sure this branch is up to date with dev? I see there a conflict in run_test_case.py, let me know if you need assistance resolving it.

@BradfordBates-NOAA
Copy link
Member

@nickchadwick-noaa Please ensure the Changelog is updated

@BradfordBates-NOAA
Copy link
Member

BradfordBates-NOAA commented Jul 7, 2021

@nickchadwick-noaa Can you also do a full BED (FR & MS) test using the API to confirm non-zero exit statuses in all HUCs? And please copy the results to outputs on the development VM.

@nickchadwick-noaa nickchadwick-noaa changed the title [3pt] Cahaba Codebase Cleanup - Small Items [9pt] Cahaba Codebase Cleanup - Small Items Aug 17, 2021
@BradfordBates-NOAA BradfordBates-NOAA changed the title [9pt] Cahaba Codebase Cleanup - Small Items [9pt] PR: Cahaba Codebase Cleanup - Small Items Aug 18, 2021
@BradfordBates-NOAA BradfordBates-NOAA merged commit 8949dc3 into dev Aug 18, 2021
@BradfordBates-NOAA BradfordBates-NOAA deleted the dev-cleanup branch August 18, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file refactoring Refacting code to obtain the same result
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants