-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Remove Great Lakes from wbd buffer #375
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ahaba into dev-greatlakes_hotfix
per conversation with @RyanSpies-NOAA, removing NWM Great Lakes polygons to reduce processing time in `split_flows.py`
RyanSpies-NOAA
approved these changes
May 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Great Lakes from wbd buffer. Resolves issue #374
Changes
-The
gl_water_polygons.gpkg
layer is used to mask out Great Lakes boundaries and remove NHDPlus HR coastline segments. These segments are causing issues later inrun_by_unit.sh
and unnecessarily increasing total processing time.The work done on this feature branch is mostly recycled from @RyanSpies-NOAA's feature branch
dev-ocean-mask-dem
.Testing
Resolves non-zero exit codes for MS Great Lakes HUCs. No errors with FR/MS non-Great Lakes HUCS
Screenshots
FIM v3.0.15.9 MS streams for HUC 04040002

MS streams and catchments for HUC 04040002 with hotfix

Notes
Geopandas (Shapely) buffer doesn't have the same precision as GDAL so there is a slight difference in the WBD buffer layer geometries. The buffer is set to 5000 m and should be well beyond the HUC extent and I changed the Shapely default buffer resolution so the difference is negligible though.