Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Remove Great Lakes from wbd buffer #375

Merged
merged 13 commits into from
May 7, 2021
Merged

Conversation

BrianAvant
Copy link

Remove Great Lakes from wbd buffer. Resolves issue #374

Changes

-The gl_water_polygons.gpkg layer is used to mask out Great Lakes boundaries and remove NHDPlus HR coastline segments. These segments are causing issues later in run_by_unit.sh and unnecessarily increasing total processing time.

The work done on this feature branch is mostly recycled from @RyanSpies-NOAA's feature branch dev-ocean-mask-dem.

Testing

Resolves non-zero exit codes for MS Great Lakes HUCs. No errors with FR/MS non-Great Lakes HUCS

Screenshots

FIM v3.0.15.9 MS streams for HUC 04040002
image

MS streams and catchments for HUC 04040002 with hotfix
image

Notes

Geopandas (Shapely) buffer doesn't have the same precision as GDAL so there is a slight difference in the WBD buffer layer geometries. The buffer is set to 5000 m and should be well beyond the HUC extent and I changed the Shapely default buffer resolution so the difference is negligible though.

@BrianAvant BrianAvant added the bug Something isn't working label May 4, 2021
@BrianAvant BrianAvant added this to the FIM v3.X milestone May 4, 2021
@BrianAvant BrianAvant requested a review from RyanSpies-NOAA May 4, 2021 19:26
Copy link
Collaborator

@RyanSpies-NOAA RyanSpies-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this feature branch on huc 04080104. Confirmed that this runs for both MS & FR and produces desired results (removes NHDPlus coastline segments and improves fim_run runtime).
image

@nickchadwick-noaa nickchadwick-noaa merged commit 22ba0df into dev May 7, 2021
@nickchadwick-noaa nickchadwick-noaa deleted the dev-greatlakes_hotfix branch May 7, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants