[1pt] PR: Incorporate CatFIM flows into Sierra Test and add AHPS benchmark preprocessing scripts.

[TrevorGrout-NOAA]

This PR addresses Tickets #341, #361, #357

Additions

• Added preprocessing scripts:
  *preprocess_download_usgs_grids.py: Downloads data from USGS FIM studies
  *preprocess_ahps_usgs.py: Produces benchmark USGS datasets
  *preprocess_ahps_nws.py: Produces benchmark NWS datasets

The preprocessing scripts are meant to be run on the local workstation, not the VM, and require numerous file dependencies.

• rating_curve_get_usgs_gages.py: added functionality to produce csv containing all categorical thresholds for each USGS gage site.
• Added variables to .env.template associated with preprocessing ahps datasets.

Removals

Changes

-Updated rating_curve_comparison.py to ingest categorical threshold flows for each USGS gage site.

• Updated eval_plots.py to produce individual plots in same directory instead of in nested subdirectories

Testing

1. Preprocessing not functional on VM due to numerous file dependencies. It was tested and verified that it worked on the workstation connected to NWC network

2. To run eval_plots with new individual setting:
   python3 eval_plots.py -m /path/to/all_official_versions.csv -v fim_3_0_15_2_ms -i -w /path/to/workspace
   

3. To run sierra test with new catfim flows
   python3 rating_curve_comparison.py -fim_dir /path/to/fimdir -output_dir /path/to/outputs -gages /path/to/usgs_rating_curves.csv -flows /path/to/nwm_recurr_flows -catfim /path/to/catfim_flows_cms.csv -j 10 -group 'location_id recurr_interval'

Screenshots

Notes

Todos

Checklist

• PR has an informative and human-readable title
• Changes are limited to a single goal (no scope creep)
• Code can be automatically merged (no conflicts)
• Code follows project standards (link if applicable)
• Passes all existing automated tests
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future todos are captured in comments
• Visually tested in supported browsers and devices (see checklist below 👇)
• Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
• Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

• Windows
• Linux
• Browser

Accessibility

• Keyboard friendly
• Screen reader friendly

Other

• Is useable without CSS
• Is useable without JS
• Flexible from small to large screens
• No linting errors or warnings
• JavaScript tests are passing

[TrevorGrout-NOAA]

The preprocessing scripts were successfully run on local workstations at the NWC. Ryan Spies reviewed the original preprocessing scripts in January. This version of the preprocessing scripts were altered to account for WRDS updates and to update the analysis extent to have holes filled.

[TrevorGrout-NOAA]

@nickchadwick-noaa @BradfordBates-NOAA this is ready to be merged in with dev.