bug_fix_AET #142
Open
bug_fix_AET #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extracted from the soil.
fred-ogden
reviewed
Mar 3, 2025
| @@ -3325,11 +3326,12 @@ extern void mass_balance_check(cfe_state_struct* cfe_ptr){ | |||
| giuh_residual = cfe_ptr->vol_struct.vol_runoff - cfe_ptr->vol_struct.vol_out_surface - cfe_ptr->vol_struct.vol_end_surface - | |||
| cfe_ptr->vol_struct.vol_runon_infilt; | |||
There was a problem hiding this comment.
Question: is vol_struct>vol_et_from_retention_depth included in cfe_ptr->vol_struct.vol_end_surfaced? Secong question, should this mass balance equation on line 3325 be: giuh_residual = cfe_ptr->vol_struct.vol_runoff - cfe_ptr->vol_struct.vol_out_surface - cfe_ptr->vol_struct.vol_end_surface - cfe_ptr->vol_struct.vol_runon_infilt - cfe_ptr->vol-struct.vol_et_from_retention_depth; ?
Merged
ajkhattak
added a commit
that referenced
this pull request
Mar 13, 2025
* chore: small formatting refactor Co-authored-by: ajkhattak <ajkhattak@gmail.com> * feat: add method to compute et_from_retention_depth Co-authored-by: ajkhattak <ajkhattak@gmail.com> * fix: take AET from surface retention depth Co-authored-by: ajkhattak <ajkhattak@gmail.com> * fix: try to prevent segfault when computing AET from retention depth --------- Co-authored-by: ajkhattak <ajkhattak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes a bug in the AET extraction. The AET should come from surface water retention depth before it is extracted from the soil.
Additions
Removals
Changes
Testing
Checklist