Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new_ua_temp_colormaps #251

Merged
merged 3 commits into from
Feb 24, 2025
Merged

new_ua_temp_colormaps #251

merged 3 commits into from
Feb 24, 2025

Conversation

Brian-Jamison
Copy link
Collaborator

These are some requested changes in the 925mb, 850mb, 700mb, and 500mb temperature contours, to clearly delineate the 0 deg line and provide more clarity in the -5 to +5 C range. The 500mb scale was changed to match the scales at the other levels.

image
image

These are some requested changes in the 925mb, 850mb, 700mb, and 500mb temperature contours, to clearly delineate the 0 deg line and provide more clarity in the -5 to +5 C range.  The 500mb scale was changed to match the scales at the other levels.
Copy link
Collaborator

@cshartsough cshartsough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the pytest failed but it wasn't clear right offhand what the issue is. I can help look at it more if you don't see the problem either. Otherwise it seems to fit the logic pretty well, so should be able to approve after this fix.

@Brian-Jamison
Copy link
Collaborator Author

I see the pytest failed but it wasn't clear right offhand what the issue is. I can help look at it more if you don't see the problem either. Otherwise it seems to fit the logic pretty well, so should be able to approve after this fix.

I'm not quite sure what the problem is, either. The range(17, 1, -2) gives 17, 15, 13, 11, 9, 7, 5, 3 (8 values) and that's done twice, so 16 values below zero, and 16 other values in the "ncar" part of the table, above zero. That matches the number of colors in the current plot, so I don't know exactly what's wrong.

@cshartsough
Copy link
Collaborator

The test thinks that clevs=15 and t_colors =32, but I don't see why that's the case. I see you removed the unnecessary clevs lines once &ua_temp changed, maybe that's throwing things off? I can try to test it on Monday.

Copy link
Collaborator

@cshartsough cshartsough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good solution for the last issue, let t_colors stay as is and use the new color table you had set up as a separate spec.

Good job.

@Brian-Jamison Brian-Jamison merged commit 7fe6c84 into main Feb 24, 2025
2 checks passed
@Brian-Jamison Brian-Jamison deleted the new_ua_temp_colormaps branch February 24, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants