Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs found in pbl and ozone 3d diagnostic tendencies #26

Conversation

SamuelTrahanNOAA
Copy link
Collaborator

@SamuelTrahanNOAA SamuelTrahanNOAA commented May 8, 2020

PBL tendencies were missing in two schemes; now fixed.

ccpp PR: NOAA-GSL/ccpp-physics#27

ufs-weather-model PR: NOAA-GSL/ufs-weather-model#20

@climbfuji
Copy link

I see a ton of messages like

 69:  NO FLAG: dcnv is generic
119:  FLAG: gwd_opt==1 so gwd not generic
119:  FLAG: satmedmf and isatedmf=1 so pbl not generic
119:  NO FLAG: scnv is generic
119:  NO FLAG: dcnv is generic
 94:  FLAG: gwd_opt==1 so gwd not generic
 94:  FLAG: satmedmf and isatedmf=1 so pbl not generic
 94:  NO FLAG: scnv is generic
 94:  NO FLAG: dcnv is generic
 11:  FLAG: gwd_opt==1 so gwd not generic
 11:  FLAG: satmedmf and isatedmf=1 so pbl not generic
 11:  NO FLAG: scnv is generic
 11:  NO FLAG: dcnv is generic
 73:  FLAG: gwd_opt==1 so gwd not generic
 73:  FLAG: satmedmf and isatedmf=1 so pbl not generic
 73:  NO FLAG: scnv is generic
 73:  NO FLAG: dcnv is generic
120:  FLAG: gwd_opt==1 so gwd not generic
120:  FLAG: satmedmf and isatedmf=1 so pbl not generic
120:  NO FLAG: scnv is generic
120:  NO FLAG: dcnv is generic
 99:  FLAG: gwd_opt==1 so gwd not generic
 99:  FLAG: satmedmf and isatedmf=1 so pbl not generic

in the output. We should only print those for the master task in GFS_typedefs.F90. Somehow this slipped through the review when the original tendencies code was merged a few weeks back.

@DomHeinzeller
Copy link

fv3atm was just updated (PR #27; submodule pointer update only). Please update your branch. Thanks!

@SamuelTrahanNOAA
Copy link
Collaborator Author

The aforementioned problems are resolved in my latest commit.

@DomHeinzeller
Copy link

I merged NOAA-GSL/ccpp-physics#27. Can you please update the submodule pointer for ccpp-physics in your fv3atm branch to point to:

commit 238c84cb3c789056c701b70d3373e640ed4fa599 (HEAD, origin/gsd/develop, origin/HEAD)
Author: Samuel Trahan (NOAA contractor) <39415369+SamuelTrahanNOAA@users.noreply.github.com>
Date:   Wed May 13 22:20:32 2020 -0400

    fix bugs found in pbl and ozone 3d diagnostic tendencies (#27)

    PBL tendencies were missing in two schemes; now fixed. Squashed commit of:
    * fix bugs found in pbl and ozone 3d diagnostic tendencies
    * remove debugging prints
    * implied shape arrays for five variables
    * more block labels
    * yet more bug fixes

Then, fix the merge conflict for ufs-weather-model and update the submodule pointer for fv3atm. Once this is done, I can approve and merge fv3atm. Thanks!

@DomHeinzeller DomHeinzeller merged commit bfe13b0 into NOAA-GSL:gsd/develop May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants