Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update btstep negative eta warning #844

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

awallcraft
Copy link

In Boussinesq mode the eta below bathyT warning includes the location, but in non-Boussinesq mode the corresponding negative eta warning does not.

Added the location to the negative eta warning.

No answers are changed.

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.69%. Comparing base (5e4f97b) to head (e13b8f7).
Report is 1 commits behind head on dev/gfdl.

❗ There is a different number of reports uploaded between BASE (5e4f97b) and HEAD (e13b8f7). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5e4f97b) HEAD (e13b8f7)
2 1
Additional details and impacted files
@@              Coverage Diff              @@
##           dev/gfdl     #844       +/-   ##
=============================================
- Coverage     38.10%   21.69%   -16.41%     
=============================================
  Files           298      137      -161     
  Lines         87711    33202    -54509     
  Branches      16447     5951    -10496     
=============================================
- Hits          33418     7202    -26216     
+ Misses        48264    25443    -22821     
+ Partials       6029      557     -5472     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this useful functional improvement in the information content of these error messages.

My only very minor quibble here is that the MOM6 style guide at https://github.com/mom-ocean/MOM6/wiki/Code-style-guide#white-space strongly encourages the use of 4 or more spaces of indenting for continuation lines, rather than the 2 lines as used here.

@Hallberg-NOAA Hallberg-NOAA added the documentation Improvements or additions to documentation label Mar 3, 2025
Copy link
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this valuable enhancement to add information content to an error message.

In Boussinesq mode the eta below bathyT warning includes the location,
but in non-Boussinesq mode the corresponding negative eta warning does not.

Added the location to the negative eta warning.

No answers are changed.
@Hallberg-NOAA
Copy link
Member

This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26602.

@Hallberg-NOAA Hallberg-NOAA merged commit e3e9c69 into NOAA-GFDL:dev/gfdl Mar 4, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants