-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update btstep negative eta warning #844
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #844 +/- ##
=============================================
- Coverage 38.10% 21.69% -16.41%
=============================================
Files 298 137 -161
Lines 87711 33202 -54509
Branches 16447 5951 -10496
=============================================
- Hits 33418 7202 -26216
+ Misses 48264 25443 -22821
+ Partials 6029 557 -5472 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this useful functional improvement in the information content of these error messages.
My only very minor quibble here is that the MOM6 style guide at https://github.com/mom-ocean/MOM6/wiki/Code-style-guide#white-space strongly encourages the use of 4 or more spaces of indenting for continuation lines, rather than the 2 lines as used here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this valuable enhancement to add information content to an error message.
In Boussinesq mode the eta below bathyT warning includes the location, but in non-Boussinesq mode the corresponding negative eta warning does not. Added the location to the negative eta warning. No answers are changed.
ec29728
to
41ed391
Compare
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26602. |
In Boussinesq mode the eta below bathyT warning includes the location, but in non-Boussinesq mode the corresponding negative eta warning does not.
Added the location to the negative eta warning.
No answers are changed.