+Add PHILLIPS_ANSWER_DATE runtime parameter #804
Merged
+124
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallberg-NOAA
added
enhancement
marshallward
approved these changes
Feb 10, 2025
Add the new runtime parameter PHILLIPS_ANSWER_DATE to enable the option to use mathematically equivalent expressions in Phillips_initialize_velocity() that exactly specify the arithmetic to be used, avoid excess divisions and permit full rescaling of the internal variables and the elimination of rescaling variables. This new slightly answer-changing option is enabled by setting PHILLIPS_ANSWER_DATE >= 20250101. For now, the default for PHILLIPS_ANSWER_DATE is set to 20241231 to avoid changing answers without explicitly setting it. This commit also introduces code to use G%grid_unit_to_L to detect and handle various choices for the units of the G%geolat and G%geolon variables. By default, all answers are bitwise identical, but there is a new runtime parameter in some MOM_parameter_doc files. This commit changes answers at roundoff when there is an explicit setting of PHILLIPS_ANSWER_DATE >= 20250101,
Hallberg-NOAA
force-pushed
the
add_PHILLIPS_ANSWER_DATE
branch
from
076ce9a to
6686f17
Compare
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26352. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the new runtime parameter PHILLIPS_ANSWER_DATE to enable the option to use mathematically equivalent expressions in
Phillips_initialize_velocity()that exactly specify the arithmetic to be used, avoid excess divisions and permit full rescaling of the internal variables and the elimination of rescaling variables. This new slightly answer-changing option is enabled by settingPHILLIPS_ANSWER_DATE >= 20250101. For now, the default forPHILLIPS_ANSWER_DATEis set to 20241231 to avoid changing answers without explicitly setting it.This commit also introduces code to use
G%grid_unit_to_Lto detect and handle various choices for the units of theG%geolatandG%geolonvariables.By default, all answers are bitwise identical, but there is a new runtime parameter in some MOM_parameter_doc files. This commit changes answers at roundoff when there is an explicit setting of
PHILLIPS_ANSWER_DATE >= 20250101.