Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.testing: Codecov upload uses Github Actions token #490

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

marshallward
Copy link
Member

Anonymous uploads to Codecov are throttled (though it is not clear if this is happening on the Codecov or the GitHub Actions side). Regardless, the advice to get around this throttling seems to be to use the Codecov token associated with the project.

The .testing Makefile was modified to use this token if provided, and the GitHub Actions environment now attempts to fetch this from the secrets of the repository.

Hopefully individual groups can set this for their own projects, and it will fall back to anonymous upload if unset, but I guess we'll have to see how this plays out.

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #490 (b8edd61) into dev/gfdl (13f2603) will not change coverage.
The diff coverage is n/a.

❗ Current head b8edd61 differs from pull request most recent head c7f0fdf. Consider uploading reports for the commit c7f0fdf to get more accurate results

@@            Coverage Diff            @@
##           dev/gfdl     #490   +/-   ##
=========================================
  Coverage     37.84%   37.84%           
=========================================
  Files           270      270           
  Lines         78244    78244           
  Branches      14481    14481           
=========================================
  Hits          29609    29609           
  Misses        43244    43244           
  Partials       5391     5391           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Anonymous uploads to Codecov are throttled (though it is not clear if
this is happening on the Codecov or the GitHub Actions side).
Regardless, the advice to get around this throttling seems to be to use
the Codecov token associated with the project.

The .testing Makefile was modified to use this token if provided, and
the GitHub Actions environment now attempts to fetch this from the
secrets of the repository.

Hopefully individual groups can set this for their own projects, and it
will fall back to anonymous upload if unset, but I guess we'll have to
see how this plays out.
@adcroft adcroft force-pushed the codecov_token_upload branch from c01f0ce to c7f0fdf Compare October 5, 2023 21:29
@adcroft adcroft merged commit a41d0a0 into NOAA-GFDL:dev/gfdl Oct 5, 2023
@marshallward marshallward deleted the codecov_token_upload branch May 8, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants