Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Kelvin wave issues #848

Open
kshedstrom opened this issue Mar 4, 2025 · 0 comments
Open

Some Kelvin wave issues #848

kshedstrom opened this issue Mar 4, 2025 · 0 comments

Comments

@kshedstrom
Copy link

As discussed in #839 some issues remain:

  1. Taking out the 0.001 will make it run and should be done. Note that the amplitude for the baroclinic case then needs to be decreased (0.5 works).
  2. Taking out the square of the velocity magnitude renders the units incorrect. What is the proper fix?
  3. One could rewrite things calling wave_speed()
  4. @Hallberg-NOAA proposes a form for eta_anom at the boundaries. We don't currently apply any interface height OBCs except no gradient.
kshedstrom added a commit to ESMG/MOM6 that referenced this issue Mar 5, 2025
@kshedstrom
*Improvements to internal Kelvin wave
50766d6 
- Takes care of first two problems in issue NOAA-GFDL#848.
- It now runs with amplitude of 0.5.
@kshedstrom kshedstrom mentioned this issue Mar 5, 2025
Merged
Hallberg-NOAA pushed a commit to ESMG/MOM6 that referenced this issue Mar 6, 2025
@kshedstrom @Hallberg-NOAA
*Improvements to internal Kelvin wave
2782ab3 
- Takes care of first two problems in issue NOAA-GFDL#848.
- It now runs with amplitude of 0.5.
Hallberg-NOAA pushed a commit that referenced this issue Mar 6, 2025
@kshedstrom
*Improvements to internal Kelvin wave (#849)
9e3cc84 
* *Improvements to internal Kelvin wave

- Takes care of first two problems in issue #848.
- It now runs with amplitude of 0.5.

* Removed commented out warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kshedstrom