Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTERPOLATE_SPONGE_TIME_SPACE not recorded in MOM_parameter_doc.short #46

Closed
kshedstrom opened this issue Dec 18, 2021 · 0 comments · Fixed by #87
Closed

INTERPOLATE_SPONGE_TIME_SPACE not recorded in MOM_parameter_doc.short #46

kshedstrom opened this issue Dec 18, 2021 · 0 comments · Fixed by #87

Comments

@kshedstrom
Copy link

The result of this code:

  call get_param(param_file, mdl, "NEW_SPONGES", time_space_interp_sponge, &
                 "Set True if using the newer sponging code which "//&
                 "performs on-the-fly regridding in lat-lon-time.",&
                 "of sponge restoring data.", default=.false.)
  if (time_space_interp_sponge) then 
    call MOM_error(WARNING, " initialize_sponges:  NEW_SPONGES has been deprecated. "//&
                   "Please use INTERPOLATE_SPONGE_TIME_SPACE instead. Setting "//&
                   "INTERPOLATE_SPONGE_TIME_SPACE = True.")
  endif
  call get_param(param_file, mdl, "INTERPOLATE_SPONGE_TIME_SPACE", time_space_interp_sponge, &
                 "Set True if using the newer sponging code which "//&
                 "performs on-the-fly regridding in lat-lon-time.",&
                 "of sponge restoring data.", default=time_space_interp_sponge)

is that INTERPOLATE_SPONGE_TIME_SPACE registers as default = True and therefore not recorded in the .short file.
@Hallberg-NOAA Hallberg-NOAA mentioned this issue Mar 12, 2022
Merged
@Hallberg-NOAA Hallberg-NOAA linked a pull request Mar 12, 2022 that will close this issue
+Stop logging NEW_SPONGES #87
Merged
Hallberg-NOAA added a commit that referenced this issue Mar 22, 2022
@Hallberg-NOAA
+Stop logging NEW_SPONGES
d560169 
  Stop logging the deprecated run-time parameter NEW_SPONGES, and always log
INTERPOLATE_SPONGE_TIME_SPACE as if NEW_SPONGES were not used.  This commit will
address MOM6 issue #46, which can be closed it is accepted.  This will change
the MOM_parameter_doc entries in some cases, but all answers are bitwise
identical.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

+Stop logging NEW_SPONGES Hallberg-NOAA/MOM6
1 participant
@kshedstrom