Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexibility when writing restart files #372

Closed
cspencerjones opened this issue May 24, 2023 · 1 comment
Closed

More flexibility when writing restart files #372

cspencerjones opened this issue May 24, 2023 · 1 comment

Comments

@cspencerjones
Copy link

At the moment, save_restart is called directly by the drivers, e.g. here. I would like to option to save non-standard restart files that contain particle locations, but I cannot currently do so without writing new code in all of the drivers (which doesn't seem ideal).

I would like it if the driver could call a new subroutine that we could add to MOM.F90, and that subroutine could call save_restart. Then any extra steps in the save_restart process could be added only in one place in the code. This would help me directly, but is also likely to help others who might want to add to the code in the future.

I talked to @adcroft about this several months ago. He seemed to be on board with the idea. I am posting here to create a paper trail and to start a discussion on whether/how to make this happen.

marshallward pushed a commit that referenced this issue Jul 12, 2023
As described in issue #372, I would like to be able to create restart files that
contain information about the particle location. These files will be written at
the same time as other restart files. I cannot add these calls directly to the
driver, because the driver does not have information about the particle location.
We have added save_MOM6_internal_state as a subroutine in MOM.F90, and
we added calls to this subroutine from each of the drivers. We hope this will
allow for more new packages to write restart files in the future.

Co-authored by Spencer Jones <spencerjones@tamu.edu>
@marshallward
Copy link
Member

I believe this has been addressed; we now have a clear space for generalizing restarts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants